Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix SA5011 static check in ibc/../chain.go #9333

Merged
merged 1 commit into from
May 17, 2021

Conversation

robert-zaremba
Copy link
Collaborator

@robert-zaremba robert-zaremba commented May 14, 2021

Description

linter was doing a false positive in IBC tests and blocking one PRs.

closes: #9332


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@robert-zaremba robert-zaremba added A:automerge Automatically merge PR once all prerequisites pass. T: Tests labels May 14, 2021
@amaury1093 amaury1093 self-assigned this May 17, 2021
@aaronc aaronc merged commit 4aef38b into release/v0.42.x May 17, 2021
@aaronc aaronc deleted the robert/ibc-create-tm-client-header branch May 17, 2021 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. T: Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants