refactor: Move some methods inside TX Factory #9421

jgimeno · 2021-05-28T13:55:36Z

Description

Putting some things inside the factory (which was very anemic struct) has helped me to understand the flow. Feel free to merge if you see some benefit.

closes: #XXXX

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
Code follows the module structure standards.
Wrote unit and integration tests
Updated relevant documentation (docs/) or specification (x/<module>/spec/)
Added relevant godoc comments.
Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
Re-reviewed Files changed in the Github PR explorer
Review Codecov Report in the comment section below once CI passes

codecov · 2021-05-28T14:19:49Z

Codecov Report

Merging #9421 (179d9e1) into master (0027111) will increase coverage by 25.22%.
The diff coverage is 62.90%.

❗ Current head 179d9e1 differs from pull request most recent head 482edf6. Consider uploading reports for the commit 482edf6 to get more accurate results

@@             Coverage Diff             @@
##           master    #9421       +/-   ##
===========================================
+ Coverage   35.48%   60.70%   +25.22%     
===========================================
  Files         332      588      +256     
  Lines       32620    37277     +4657     
===========================================
+ Hits        11575    22629    +11054     
+ Misses      19819    12698     -7121     
- Partials     1226     1950      +724

Impacted Files	Coverage Δ
client/keys/show.go	`83.67% <ø> (-0.24%)`	⬇️
client/keys/types.go	`100.00% <ø> (+100.00%)`	⬆️
client/keys/utils.go	`42.85% <ø> (+2.50%)`	⬆️
client/query.go	`16.98% <ø> (ø)`
client/rpc/block.go	`10.00% <ø> (ø)`
client/rpc/routes.go	`100.00% <ø> (ø)`
client/rpc/status.go	`47.72% <ø> (ø)`
client/rpc/validators.go	`0.00% <ø> (ø)`
client/test_helpers.go	`0.00% <ø> (ø)`
client/tx/factory.go	`27.00% <ø> (ø)`
... and 699 more

tac0turtle

I am a fan of this change!! utACK

Could you add a changelog entry please?

amaury1093

Seems like an API improvement to me too. Could you add a changelog entry?

Since this is an API-breaking change, I would rather wait for 0.43-rc to be out before merging.

tac0turtle · 2021-06-02T12:00:05Z

Since this is an API-breaking change, I would rather wait for 0.43-rc to be out before merging.

Whats the difference with getting this in before vs after?

amaury1093 · 2021-06-02T12:05:21Z

We decided in #9116 to freeze master of unnecessary API breaking changes. Once the beta phase is done, we'll create a release/v0.43.x branch, so normal dev work (like this PR) can go to master again.

aaronc · 2021-06-02T14:26:09Z

Since this is an API-breaking change, I would rather wait for 0.43-rc to be out before merging.

Whats the difference with getting this in before vs after?

We're trying our best to stick to the principle of a beta actually being a beta. We didn't with Stargate and that extended the release timeline IMHO...

tac0turtle · 2021-06-02T14:28:08Z

We're trying our best to stick to the principle of a beta actually being a beta. We didn't with Stargate and that extended the release timeline IMHO...

Makes sense, could we get the contributing.md file updated to reflect this process.

amaury1093

This can finally be merged! @jgimeno could you add a CHangelog entry too?

jgimeno · 2021-06-28T09:03:35Z

Absolutely!

CHANGELOG.md

…to jonathan/tx-cleanup

robert-zaremba · 2021-08-31T16:11:53Z

@Mergifyio backport release/v0.44.x

## Description  Putting some things inside the factory (which was very anemic struct) has helped me to understand the flow. Feel free to merge if you see some benefit. closes: #XXXX --- Before we can merge this PR, please make sure that all the following items have been checked off. If any of the checklist items are not applicable, please leave them but write a little note why. - [ ] Targeted PR against correct branch (see [CONTRIBUTING.md](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work. - [ ] Code follows the [module structure standards](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules/structure.md). - [ ] Wrote unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] Updated relevant documentation (`docs/`) or specification (`x/<module>/spec/`) - [ ] Added relevant `godoc` [comments](https://blog.golang.org/godoc-documenting-go-code). - [ ] Added a relevant changelog entry to the `Unreleased` section in `CHANGELOG.md` - [ ] Re-reviewed `Files changed` in the Github PR explorer - [ ] Review `Codecov Report` in the comment section below once CI passes (cherry picked from commit e17be87) # Conflicts: # CHANGELOG.md

mergify · 2021-08-31T16:12:38Z

Command backport release/v0.44.x: success

Backports have been created

#10039 refactor: Move some methods inside TX Factory (backport #9421) has been created for branch release/v0.44.x

* refactor: Move some methods inside TX Factory (#9421)  ## Description  Putting some things inside the factory (which was very anemic struct) has helped me to understand the flow. Feel free to merge if you see some benefit. closes: #XXXX --- Before we can merge this PR, please make sure that all the following items have been checked off. If any of the checklist items are not applicable, please leave them but write a little note why. - [ ] Targeted PR against correct branch (see [CONTRIBUTING.md](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work. - [ ] Code follows the [module structure standards](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules/structure.md). - [ ] Wrote unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] Updated relevant documentation (`docs/`) or specification (`x/<module>/spec/`) - [ ] Added relevant `godoc` [comments](https://blog.golang.org/godoc-documenting-go-code). - [ ] Added a relevant changelog entry to the `Unreleased` section in `CHANGELOG.md` - [ ] Re-reviewed `Files changed` in the Github PR explorer - [ ] Review `Codecov Report` in the comment section below once CI passes (cherry picked from commit e17be87) # Conflicts: # CHANGELOG.md * Update CHANGELOG.md Co-authored-by: Jonathan Gimeno <jgimeno@gmail.com> Co-authored-by: Robert Zaremba <robert@zaremba.ch>

#10039)" This reverts commit 0155244.

* Revert "refactor: Move some methods inside TX Factory (backport #9421) (#10039)" This reverts commit 0155244. * remove conflict marks from changelog * update changelog

…osmos#10039) * refactor: Move some methods inside TX Factory (cosmos#9421)  ## Description  Putting some things inside the factory (which was very anemic struct) has helped me to understand the flow. Feel free to merge if you see some benefit. closes: #XXXX --- Before we can merge this PR, please make sure that all the following items have been checked off. If any of the checklist items are not applicable, please leave them but write a little note why. - [ ] Targeted PR against correct branch (see [CONTRIBUTING.md](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work. - [ ] Code follows the [module structure standards](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules/structure.md). - [ ] Wrote unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] Updated relevant documentation (`docs/`) or specification (`x/<module>/spec/`) - [ ] Added relevant `godoc` [comments](https://blog.golang.org/godoc-documenting-go-code). - [ ] Added a relevant changelog entry to the `Unreleased` section in `CHANGELOG.md` - [ ] Re-reviewed `Files changed` in the Github PR explorer - [ ] Review `Codecov Report` in the comment section below once CI passes (cherry picked from commit e17be87) # Conflicts: # CHANGELOG.md * Update CHANGELOG.md Co-authored-by: Jonathan Gimeno <jgimeno@gmail.com> Co-authored-by: Robert Zaremba <robert@zaremba.ch>

* Revert "refactor: Move some methods inside TX Factory (backport cosmos#9421) (cosmos#10039)" This reverts commit 0155244. * remove conflict marks from changelog * update changelog

…osmos#10039) * refactor: Move some methods inside TX Factory (cosmos#9421)  ## Description  Putting some things inside the factory (which was very anemic struct) has helped me to understand the flow. Feel free to merge if you see some benefit. closes: #XXXX --- Before we can merge this PR, please make sure that all the following items have been checked off. If any of the checklist items are not applicable, please leave them but write a little note why. - [ ] Targeted PR against correct branch (see [CONTRIBUTING.md](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work. - [ ] Code follows the [module structure standards](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules/structure.md). - [ ] Wrote unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] Updated relevant documentation (`docs/`) or specification (`x/<module>/spec/`) - [ ] Added relevant `godoc` [comments](https://blog.golang.org/godoc-documenting-go-code). - [ ] Added a relevant changelog entry to the `Unreleased` section in `CHANGELOG.md` - [ ] Re-reviewed `Files changed` in the Github PR explorer - [ ] Review `Codecov Report` in the comment section below once CI passes (cherry picked from commit e17be87) # Conflicts: # CHANGELOG.md * Update CHANGELOG.md Co-authored-by: Jonathan Gimeno <jgimeno@gmail.com> Co-authored-by: Robert Zaremba <robert@zaremba.ch>

* Revert "refactor: Move some methods inside TX Factory (backport cosmos#9421) (cosmos#10039)" This reverts commit 0155244. * remove conflict marks from changelog * update changelog

…osmos#10039) * refactor: Move some methods inside TX Factory (cosmos#9421)  ## Description  Putting some things inside the factory (which was very anemic struct) has helped me to understand the flow. Feel free to merge if you see some benefit. closes: #XXXX --- Before we can merge this PR, please make sure that all the following items have been checked off. If any of the checklist items are not applicable, please leave them but write a little note why. - [ ] Targeted PR against correct branch (see [CONTRIBUTING.md](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work. - [ ] Code follows the [module structure standards](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules/structure.md). - [ ] Wrote unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] Updated relevant documentation (`docs/`) or specification (`x/<module>/spec/`) - [ ] Added relevant `godoc` [comments](https://blog.golang.org/godoc-documenting-go-code). - [ ] Added a relevant changelog entry to the `Unreleased` section in `CHANGELOG.md` - [ ] Re-reviewed `Files changed` in the Github PR explorer - [ ] Review `Codecov Report` in the comment section below once CI passes (cherry picked from commit e17be87) # Conflicts: # CHANGELOG.md * Update CHANGELOG.md Co-authored-by: Jonathan Gimeno <jgimeno@gmail.com> Co-authored-by: Robert Zaremba <robert@zaremba.ch>

* Revert "refactor: Move some methods inside TX Factory (backport cosmos#9421) (cosmos#10039)" This reverts commit 0155244. * remove conflict marks from changelog * update changelog

move some generate commands to factory

4238dc9

github-actions bot added C:CLI C:x/auth labels May 28, 2021

jgimeno added 3 commits May 28, 2021 15:58

remove print unsigned tx message

990ce36

fix linter

9c975bd

Merge branch 'master' into jonathan/tx-cleanup

25b4ffd

github-actions bot added the C:x/genutil genutil module issues label May 28, 2021

jgimeno changed the title ~~Move some methods inside TX Factory~~ refactor: Move some methods inside TX Factory May 28, 2021

add prepare

bf1b1f1

jgimeno marked this pull request as ready for review May 28, 2021 15:33

jgimeno requested review from aaronc and alexanderbez as code owners May 28, 2021 15:33

tac0turtle approved these changes May 31, 2021

View reviewed changes

tac0turtle requested review from amaury1093 and robert-zaremba May 31, 2021 07:25

amaury1093 suggested changes Jun 2, 2021

View reviewed changes

blushi added the S: DO NOT MERGE Status: DO NOT MERGE label Jun 17, 2021

amaury1093 reviewed Jun 28, 2021

View reviewed changes

amaury1093 removed the S: DO NOT MERGE Status: DO NOT MERGE label Jun 28, 2021

jgimeno added 2 commits June 28, 2021 05:05

Merge branch 'master' into jonathan/tx-cleanup

56e6e76

update changelog

366575f

jgimeno requested a review from amaury1093 June 28, 2021 11:11

Merge branch 'master' into jonathan/tx-cleanup

179d9e1

amaury1093 reviewed Jun 28, 2021

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

Merge branch 'jonathan/tx-cleanup' of github.com:cosmos/cosmos-sdk in…

482edf6

…to jonathan/tx-cleanup

amaury1093 approved these changes Jun 28, 2021

View reviewed changes

amaury1093 added the A:automerge Automatically merge PR once all prerequisites pass. label Jun 28, 2021

mergify bot merged commit e17be87 into master Jun 28, 2021

mergify bot deleted the jonathan/tx-cleanup branch June 28, 2021 11:42

mergify bot mentioned this pull request Aug 31, 2021

refactor: Move some methods inside TX Factory (backport #9421) #10039

Merged

robert-zaremba mentioned this pull request Sep 1, 2021

chore: release v0.44 #10048

Merged

19 tasks

robert-zaremba added a commit that referenced this pull request Sep 1, 2021

Revert "refactor: Move some methods inside TX Factory (backport #9421) (

f3c1021

#10039)" This reverts commit 0155244.

fedekunze mentioned this pull request Nov 14, 2021

all: cherry pick olympus mons tharsis/cosmos-sdk#1

Closed

19 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: Move some methods inside TX Factory #9421

refactor: Move some methods inside TX Factory #9421

jgimeno commented May 28, 2021 •

edited

Loading

codecov bot commented May 28, 2021 •

edited

Loading

tac0turtle left a comment •

edited

Loading

amaury1093 left a comment •

edited

Loading

tac0turtle commented Jun 2, 2021

amaury1093 commented Jun 2, 2021 •

edited

Loading

aaronc commented Jun 2, 2021

tac0turtle commented Jun 2, 2021

amaury1093 left a comment

jgimeno commented Jun 28, 2021

robert-zaremba commented Aug 31, 2021

mergify bot commented Aug 31, 2021

refactor: Move some methods inside TX Factory #9421

refactor: Move some methods inside TX Factory #9421

Conversation

jgimeno commented May 28, 2021 • edited Loading

Description

codecov bot commented May 28, 2021 • edited Loading

Codecov Report

tac0turtle left a comment • edited Loading

Choose a reason for hiding this comment

amaury1093 left a comment • edited Loading

Choose a reason for hiding this comment

tac0turtle commented Jun 2, 2021

amaury1093 commented Jun 2, 2021 • edited Loading

aaronc commented Jun 2, 2021

tac0turtle commented Jun 2, 2021

amaury1093 left a comment

Choose a reason for hiding this comment

jgimeno commented Jun 28, 2021

robert-zaremba commented Aug 31, 2021

mergify bot commented Aug 31, 2021

jgimeno commented May 28, 2021 •

edited

Loading

codecov bot commented May 28, 2021 •

edited

Loading

tac0turtle left a comment •

edited

Loading

amaury1093 left a comment •

edited

Loading

amaury1093 commented Jun 2, 2021 •

edited

Loading