fix: Staking delegations should return empty list instead of rpc error when no records found #9423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…khita/staking-delegations-returns-empty-list-instead-of-rpc-error-when-no-records-found
likhita-809
changed the title
Codecov Report
@@ Coverage Diff @@
## master #9423 +/- ##
==========================================
- Coverage 60.41% 60.39% -0.02%
==========================================
Files 589 589
Lines 37107 37103 -4
==========================================
- Hits 22417 22409 -8
- Misses 12712 12715 +3
- Partials 1978 1979 +1
|
atheeshp
reviewed
May 31, 2021
likhita-809
commented
May 31, 2021
aleem1314
reviewed
May 31, 2021
…khita/staking-delegations-returns-empty-list-instead-of-rpc-error-when-no-records-found
atheeshp
reviewed
May 31, 2021
…khita/staking-delegations-returns-empty-list-instead-of-rpc-error-when-no-records-found
aleem1314
approved these changes
Jun 1, 2021
…list-instead-of-rpc-error-when-no-records-found
mergify
bot
deleted the
likhita/staking-delegations-returns-empty-list-instead-of-rpc-error-when-no-records-found
branch
56 tasks
devon-chain
pushed a commit
to PundiAI/cosmos-sdk
that referenced
this pull request
May 18, 2022
…r when no records found (cosmos#9423) * return empty list instead of rpc error when no records found for staking delegations * fix grpc query DelegatorDelegations tests * remove response code tests for staking delegations * fix failing tests * change staking delegations response code to 200 in grpc test * add staking delegations response code tests to TestQueryDelegatorDelegationsGRPC * add address without delegations testcase * add changes to grpc query tests of delegatorDelegations * remove getRequest unused function from x/staking/client/rest/grpc_query_test.go * minor fixes * add testcases for request with no delegations * address review comments Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit da87ab0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #9356