Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Move simapp FundAccount and FundModuleAccount to testutil #9427

Merged
merged 19 commits into from
Jun 29, 2021
Merged

refactor: Move simapp FundAccount and FundModuleAccount to testutil #9427

merged 19 commits into from
Jun 29, 2021

Conversation

likhita-809
Copy link
Contributor

ref: #9346

@likhita-809
move FundAccount and FundModuleAccount to x/bank/client/testutil to r…
9464a60 
…emove import cycles
@likhita-809
Merge branch 'master' of https://github.com/cosmos/cosmos-sdk into li…
8e3f81b 
…khita/move-simapp-FundAccount-and-FundModuleAccount-functions-to-testutil
@likhita-809 likhita-809 assigned atheeshp and cyberbono3 and unassigned aleem1314 Jun 3, 2021
cyberbono3
cyberbono3 approved these changes Jun 3, 2021
View reviewed changes
Copy link
Contributor

@cyberbono3 cyberbono3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aleem1314 aleem1314 self-assigned this Jun 3, 2021
@codecov
Copy link

codecov bot commented Jun 3, 2021 •
edited
Loading

Codecov Report

Merging #9427 (d49efe9) into master (f65b6c9) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head d49efe9 differs from pull request most recent head 2cb485a. Consider uploading reports for the commit 2cb485a to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9427      +/-   ##
==========================================
+ Coverage   60.71%   60.72%   +0.01%     
==========================================
  Files         588      588              
  Lines       37311    37303       -8     
==========================================
  Hits        22653    22653              
+ Misses      12704    12696       -8     
  Partials     1954     1954
Impacted Files Coverage Δ
simapp/test_helpers.go 0.50% <ø> (+0.01%) ⬆️
x/auth/client/cli/tx_multisign.go 0.00% <0.00%> (ø)

likhita-809 and others added 2 commits June 4, 2021 12:49
@likhita-809
Merge branch 'master' of https://github.com/cosmos/cosmos-sdk into li…
e5b3232 
…khita/move-simapp-FundAccount-and-FundModuleAccount-functions-to-testutil
@likhita-809
Merge branch 'master' into likhita/move-simapp-FundAccount-and-FundMo…
1d8751a 
…duleAccount-functions-to-testutil
amaury1093
amaury1093 previously requested changes Jun 4, 2021
View reviewed changes
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is an API breaking change. Let's wait to merge this after the beta freeze

@blushi blushi added the S: DO NOT MERGE Status: DO NOT MERGE label Jun 4, 2021
@amaury1093 amaury1093 removed the S: DO NOT MERGE Status: DO NOT MERGE label Jun 28, 2021
amaury1093
amaury1093 reviewed Jun 28, 2021
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@amaury1093 amaury1093 dismissed their stale review June 28, 2021 08:44

rc0 out

@likhita-809
Merge branch 'master' of https://github.com/cosmos/cosmos-sdk into li…
7477c77 
…khita/move-simapp-FundAccount-and-FundModuleAccount-functions-to-testutil
@likhita-809 likhita-809 force-pushed the likhita/move-simapp-FundAccount-and-FundModuleAccount-functions-to-testutil branch from 503af25 to 7477c77 Compare June 29, 2021 04:31
@likhita-809 likhita-809 requested a review from amaury1093 June 29, 2021 06:05
@likhita-809
Merge branch 'master' of https://github.com/cosmos/cosmos-sdk into li…
2cb485a 
…khita/move-simapp-FundAccount-and-FundModuleAccount-functions-to-testutil
@amaury1093 amaury1093 added the A:automerge Automatically merge PR once all prerequisites pass. label Jun 29, 2021
@mergify mergify bot merged commit 7a8b273 into master Jun 29, 2021
@mergify mergify bot deleted the likhita/move-simapp-FundAccount-and-FundModuleAccount-functions-to-testutil branch June 29, 2021 10:23
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
@likhita-809
refactor: Move simapp FundAccount and FundModuleAccount to testutil (c…
f630982 
…osmos#9427)


ref: cosmos#9346
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleem1314 aleem1314 aleem1314 approved these changes

@atheeshp atheeshp atheeshp approved these changes

@cyberbono3 cyberbono3 cyberbono3 approved these changes

@anilcse anilcse anilcse approved these changes

@blushi blushi Awaiting requested review from blushi

@aaronc aaronc Awaiting requested review from aaronc

@alexanderbez alexanderbez Awaiting requested review from alexanderbez

@amaury1093 amaury1093 Awaiting requested review from amaury1093

Assignees

@cyberbono3 cyberbono3

@atheeshp atheeshp

@aleem1314 aleem1314

Labels
A:automerge Automatically merge PR once all prerequisites pass. C:Simulations C:x/auth C:x/authz C:x/bank C:x/distribution distribution module related C:x/feegrant C:x/genutil genutil module issues C:x/gov C:x/slashing C:x/staking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@likhita-809 @amaury1093 @anilcse @cyberbono3 @atheeshp @aleem1314 @blushi