-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Move simapp FundAccount and FundModuleAccount to testutil #9427
refactor: Move simapp FundAccount and FundModuleAccount to testutil #9427
Conversation
…emove import cycles
…khita/move-simapp-FundAccount-and-FundModuleAccount-functions-to-testutil
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
…duleAccount-functions-to-testutil
Codecov Report
@@ Coverage Diff @@
## master #9427 +/- ##
==========================================
+ Coverage 60.71% 60.72% +0.01%
==========================================
Files 588 588
Lines 37311 37303 -8
==========================================
Hits 22653 22653
+ Misses 12704 12696 -8
Partials 1954 1954
|
…khita/move-simapp-FundAccount-and-FundModuleAccount-functions-to-testutil
…duleAccount-functions-to-testutil
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is an API breaking change. Let's wait to merge this after the beta freeze
…duleAccount-functions-to-testutil
…khita/move-simapp-FundAccount-and-FundModuleAccount-functions-to-testutil
503af25
to
7477c77
Compare
…khita/move-simapp-FundAccount-and-FundModuleAccount-functions-to-testutil
ref: #9346