feat: add cosmos-sdk Version #9429

tac0turtle · 2021-05-31T08:11:43Z

Description

Add CosmosSDKVersion to nodeInfo.

closes: #9420

version/version.go

tac0turtle · 2021-06-17T06:16:53Z

@AmauryM @ruhatch unassigned you. If you want to take over the PR feel free to ping me.

codecov · 2021-06-17T07:53:17Z

Codecov Report

Merging #9429 (9311221) into master (0027111) will increase coverage by 25.10%.
The diff coverage is 62.85%.

❗ Current head 9311221 differs from pull request most recent head b6f317c. Consider uploading reports for the commit b6f317c to get more accurate results

@@             Coverage Diff             @@
##           master    #9429       +/-   ##
===========================================
+ Coverage   35.48%   60.58%   +25.10%     
===========================================
  Files         332      589      +257     
  Lines       32620    37228     +4608     
===========================================
+ Hits        11575    22556    +10981     
+ Misses      19819    12728     -7091     
- Partials     1226     1944      +718

Impacted Files	Coverage Δ
client/keys/types.go	`100.00% <ø> (+100.00%)`	⬆️
client/keys/utils.go	`42.85% <ø> (+2.50%)`	⬆️
client/query.go	`16.98% <ø> (ø)`
client/rpc/block.go	`10.00% <ø> (ø)`
client/rpc/routes.go	`100.00% <ø> (ø)`
client/rpc/status.go	`47.72% <ø> (ø)`
client/rpc/validators.go	`0.00% <ø> (ø)`
client/test_helpers.go	`0.00% <ø> (ø)`
client/tx/factory.go	`28.20% <ø> (ø)`
client/tx/legacy.go	`68.42% <ø> (ø)`
... and 700 more

amaury1093

Nice! This doesn't seem like a breaking change to me, so I'm okay to merge it to master asap. (cc @robert-zaremba)

CHANGELOG.md

amaury1093 · 2021-06-17T08:54:12Z

@AmauryM @ruhatch unassigned you. If you want to take over the PR feel free to ping me.

At our regen standups, we're trying this new method of assigning people for PR reviews, which means more or less "i'll review in the next 2 days". It seems like it gives more responsibility on the reviewer, than only pinging them as reviewer.

tac0turtle · 2021-06-17T08:55:56Z

@AmauryM @ruhatch unassigned you. If you want to take over the PR feel free to ping me.

At our regen standups, we're trying this new method of assigning people for PR reviews, which means more or less "i'll review in the next 2 days". It seems like it gives more responsibility on the reviewer, than only pinging them as reviewer.

ohhhhh, I view assignee as the person working on the PR. That is why I have all my prs assigned to me. Sorry about that

Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>

ruhatch

LGTM!

CONTRIBUTING.md

## Description Add CosmosSDKVersion to nodeInfo. closes: #9420 (cherry picked from commit 105ad99) # Conflicts: # CHANGELOG.md # CONTRIBUTING.md # docs/core/proto-docs.md

alexanderbez · 2021-06-18T12:57:31Z

version/version.go

+		Name:             Name,
+		AppName:          AppName,
+		Version:          Version,
+		GitCommit:        Commit,
+		BuildTags:        BuildTags,
+		GoVersion:        fmt.Sprintf("go version %s %s/%s", runtime.Version(), runtime.GOOS, runtime.GOARCH),
+		BuildDeps:        depsFromBuildInfo(),
+		CosmosSdkVersion: sdkVersion,


Suggested change

Name: Name,

AppName: AppName,

Version: Version,

GitCommit: Commit,

BuildTags: BuildTags,

GoVersion: fmt.Sprintf("go version %s %s/%s", runtime.Version(), runtime.GOOS, runtime.GOARCH),

BuildDeps: depsFromBuildInfo(),

CosmosSdkVersion: sdkVersion,

Name: Name,

AppName: AppName,

Version: Version,

GitCommit: Commit,

BuildTags: BuildTags,

GoVersion: fmt.Sprintf("go version %s %s/%s", runtime.Version(), runtime.GOOS, runtime.GOARCH),

BuildDeps: depsFromBuildInfo(),

CosmosSdkVersion: getSDKVersion(),

alexanderbez · 2021-06-18T12:57:40Z

version/version.go

 }

 func NewInfo() Info {
+	sdkVersion := getSDKVersion()


Suggested change

sdkVersion := getSDKVersion()

dam, will make the changes

* feat: add cosmos-sdk Version (#9429)  ## Description Add CosmosSDKVersion to nodeInfo. closes: #9420 (cherry picked from commit 105ad99) # Conflicts: # CHANGELOG.md # CONTRIBUTING.md # docs/core/proto-docs.md * resolve conflicts * resolve conflicts Co-authored-by: Marko <marbar3778@yahoo.com>

* CLI: `query ibc-transfer escrow-address` (cosmos#9383) * Fix the liveliness test Docker error (cosmos#9396) (cosmos#9402) (cherry picked from commit 44a4138) Co-authored-by: Riccardo Montagnin <riccardo.montagnin@gmail.com> * docs: fix broken interfaces links (backport cosmos#9448) (cosmos#9478) * fix interfaces links (cosmos#9448) Co-authored-by: ryanchrypto <12519942+ryanchrypto@users.noreply.github.com> Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com> (cherry picked from commit 37fc37d) # Conflicts: # docs/building-modules/messages-and-queries.md # docs/building-modules/module-interfaces.md # docs/building-modules/module-manager.md # docs/building-modules/query-services.md * resolve merge conflicts * revert rename codec Co-authored-by: Ryan Christoffersen <12519942+ryanchristo@users.noreply.github.com> Co-authored-by: ryanchrypto <12519942+ryanchrypto@users.noreply.github.com> * backport: fix ibc genesis export bug (cosmos#9401) * correctly set next identifier sequence in genesis export for clients/connections/channels * add changelog * fix linting (cosmos#9531) * fix: testnet cli command update genesis supply (backport cosmos#9497) (cosmos#9513) * fix: testnet cli command update genesis supply (cosmos#9497)  ## Description closes: cosmos#9372  ### This PR makes the `testnet` command update the bank genesis supply. When using the `testnet` cli command, it creates nodes and balances, but does **not** update the supply. When using this in conjunction with `add-genesis-account` which **does** update the supply, it creates an invalid genesis file. This PR updates the testnet command to properly set the supply. * feat: add header hash to `Context` (backport cosmos#9390) (cosmos#9395) * feat: add header hash to `Context` (cosmos#9390) * baseapp, types: add header hash to * changelog (cherry picked from commit 151d6c5) # Conflicts: # CHANGELOG.md * Fix conflicts Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com> Co-authored-by: Amaury M <1293565+amaurym@users.noreply.github.com> * fix: x/gov deposits querier (Initial Deposit) (backport cosmos#9288) (cosmos#9453) * fix: x/gov deposits querier (Initial Deposit) (cosmos#9288) * copied from old PR * fix errors * add test * Update x/gov/client/utils/query.go Co-authored-by: Robert Zaremba <robert@zaremba.ch> * fix tests * fix failing test * add test * update test * fix tests * fix deposit query * fix test * update tests * add more tests * address lint error * address lint error * review changes Co-authored-by: Robert Zaremba <robert@zaremba.ch> (cherry picked from commit 66ee994) # Conflicts: # CHANGELOG.md # x/gov/client/cli/query.go # x/gov/client/testutil/cli_test.go # x/gov/client/utils/query.go * resolve conflicts Co-authored-by: MD Aleem <72057206+aleem1314@users.noreply.github.com> Co-authored-by: aleem1314 <aleem@vitwit.com> * feat: add `RefundGas` function to `GasMeter` (backport cosmos#9403) (cosmos#9444) * feat: add `RefundGas` function to `GasMeter` (cosmos#9403) * feat: add RefundGas function to GasMeter * changelog * add comment about use case * Apply suggestions from code review Co-authored-by: Alessio Treglia <alessio@tendermint.com> Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com> (cherry picked from commit 90edeb6) # Conflicts: # CHANGELOG.md * conflicts * fix * Update CHANGELOG.md Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com> Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com> Co-authored-by: Federico Kunze <federico.kunze94@gmail.com> Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com> * fix: Bank module init genesis optimization (backport cosmos#9428) (cosmos#9440) * fix: Bank module init genesis optimization (cosmos#9428) * optimize the bank module genesis initialization * remove k.setBalances & k.clearBalances and update changelog * fix lint Co-authored-by: Aaron Craelius <aaron@regen.network> (cherry picked from commit 2ae7875) # Conflicts: # CHANGELOG.md # x/bank/keeper/genesis.go # x/bank/keeper/send.go * fix conflicts * Update CHANGELOG.md Co-authored-by: yys <sw.yunsuk@gmail.com> Co-authored-by: Amaury M <1293565+amaurym@users.noreply.github.com> * fix: update simapp to use correct default broadcast mode (backport cosmos#9408) (cosmos#9527) * fix: update simapp to use correct default broadcast mode (cosmos#9408) (cherry picked from commit 80330ec) * Add changelog Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> Co-authored-by: Amaury M <1293565+amaurym@users.noreply.github.com> * Backport: IBC query header/node-state fixes (cosmos#9385) * fix ibc query header/node-state cmds * changelog Co-authored-by: Amaury M <1293565+amaurym@users.noreply.github.com> * build(deps): tendermint version (backport cosmos#9541) (cosmos#9542) * build(deps): tendermint version (cosmos#9541) * bump tendermint version * go mod tidy (cherry picked from commit e4673ad) * add changelog entry * Update CHANGELOG.md * Update CHANGELOG.md Co-authored-by: Marko <marbar3778@yahoo.com> Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com> * feat: add cosmos-sdk Version (backport cosmos#9429) (cosmos#9543) * feat: add cosmos-sdk Version (cosmos#9429)  ## Description Add CosmosSDKVersion to nodeInfo. closes: cosmos#9420 (cherry picked from commit 105ad99) # Conflicts: # CHANGELOG.md # CONTRIBUTING.md # docs/core/proto-docs.md * resolve conflicts * resolve conflicts Co-authored-by: Marko <marbar3778@yahoo.com> * fix: set header hash every block (backport cosmos#9552) (cosmos#9555) * fix: set header hash every block (cosmos#9552) ## Description - Sets the header hash on every block (ref cosmos#9390). Previously was only set during initialization for `deliverState`. - Closes cosmos#9514  * chore: Update release notes and Changelog for 0.42.6 (cosmos#9544) * Update release notes * Clean up changelog Co-authored-by: Ethan Buchman <ethan@coinculture.info> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Riccardo Montagnin <riccardo.montagnin@gmail.com> Co-authored-by: Ryan Christoffersen <12519942+ryanchristo@users.noreply.github.com> Co-authored-by: ryanchrypto <12519942+ryanchrypto@users.noreply.github.com> Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> Co-authored-by: Marko <marbar3778@yahoo.com> Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com> Co-authored-by: Amaury M <1293565+amaurym@users.noreply.github.com> Co-authored-by: MD Aleem <72057206+aleem1314@users.noreply.github.com> Co-authored-by: aleem1314 <aleem@vitwit.com> Co-authored-by: Federico Kunze <federico.kunze94@gmail.com> Co-authored-by: yys <sw.yunsuk@gmail.com> Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>

tac0turtle added 2 commits May 31, 2021 10:10

add version flag in node_info

5ad32cd

modify test

0a9f0f2

tac0turtle marked this pull request as ready for review May 31, 2021 08:13

tac0turtle requested review from aaronc and alexanderbez as code owners May 31, 2021 08:13

tac0turtle requested review from anilcse, amaury1093, charleenfei and robert-zaremba May 31, 2021 08:14

add changelog entry

600a91c

github-actions bot added C:CLI T:Docs Changes and features related to documentation. labels May 31, 2021

tac0turtle changed the title ~~version: add cosmos-sdk Version~~ feature: add cosmos-sdk Version May 31, 2021

alexanderbez reviewed May 31, 2021

View reviewed changes

version/version.go Outdated Show resolved Hide resolved

anilcse approved these changes May 31, 2021

View reviewed changes

amaury1093 changed the title ~~feature: add cosmos-sdk Version~~ feat: add cosmos-sdk Version Jun 2, 2021

blushi assigned ruhatch Jun 10, 2021

amaury1093 self-assigned this Jun 14, 2021

tac0turtle unassigned amaury1093 and ruhatch Jun 17, 2021

tac0turtle added 2 commits June 17, 2021 08:19

Merge branch 'master' into marko/version_info

9b470da

use buildinfo

9cb048c

tac0turtle requested a review from alexanderbez June 17, 2021 06:58

Merge branch 'master' into marko/version_info

36b71d5

tac0turtle self-assigned this Jun 17, 2021

amaury1093 approved these changes Jun 17, 2021

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

Update CHANGELOG.md

aa117e9

Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>

ruhatch approved these changes Jun 17, 2021

View reviewed changes

Merge branch 'master' into marko/version_info

a150949

tac0turtle added the backport/0.42.x (Stargate) label Jun 17, 2021

amaury1093 reviewed Jun 17, 2021

View reviewed changes

CONTRIBUTING.md Outdated Show resolved Hide resolved

tac0turtle added 2 commits June 18, 2021 14:10

remove contrib edit

aad7ca0

Merge branch 'master' into marko/version_info

9311221

tac0turtle added the A:automerge Automatically merge PR once all prerequisites pass. label Jun 18, 2021

Merge branch 'master' into marko/version_info

b6f317c

mergify bot merged commit 105ad99 into master Jun 18, 2021

mergify bot deleted the marko/version_info branch June 18, 2021 12:56

mergify bot mentioned this pull request Jun 18, 2021

feat: add cosmos-sdk Version (backport #9429) #9543

Merged

alexanderbez approved these changes Jun 18, 2021

View reviewed changes

amaury1093 mentioned this pull request Jun 22, 2021

Manual Testing for v0.43 regen-network/regen-ledger#352

Closed

56 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add cosmos-sdk Version #9429

feat: add cosmos-sdk Version #9429

tac0turtle commented May 31, 2021 •

edited

Loading

tac0turtle commented Jun 17, 2021

codecov bot commented Jun 17, 2021 •

edited

Loading

amaury1093 left a comment

amaury1093 commented Jun 17, 2021

tac0turtle commented Jun 17, 2021

ruhatch left a comment

alexanderbez Jun 18, 2021

alexanderbez Jun 18, 2021

tac0turtle Jun 18, 2021 •

edited

Loading

feat: add cosmos-sdk Version #9429

feat: add cosmos-sdk Version #9429

Conversation

tac0turtle commented May 31, 2021 • edited Loading

Description

tac0turtle commented Jun 17, 2021

codecov bot commented Jun 17, 2021 • edited Loading

Codecov Report

amaury1093 left a comment

Choose a reason for hiding this comment

amaury1093 commented Jun 17, 2021

tac0turtle commented Jun 17, 2021

ruhatch left a comment

Choose a reason for hiding this comment

alexanderbez Jun 18, 2021

Choose a reason for hiding this comment

alexanderbez Jun 18, 2021

Choose a reason for hiding this comment

tac0turtle Jun 18, 2021 • edited Loading

Choose a reason for hiding this comment

tac0turtle commented May 31, 2021 •

edited

Loading

codecov bot commented Jun 17, 2021 •

edited

Loading

tac0turtle Jun 18, 2021 •

edited

Loading