feat: Add amino support for x/authz and x/feegrant #9457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #9457 +/- ##
==========================================
+ Coverage 60.39% 60.50% +0.10%
==========================================
Files 589 590 +1
Lines 37099 37342 +243
==========================================
+ Hits 22405 22592 +187
- Misses 12715 12769 +54
- Partials 1979 1981 +2
|
tac0turtle
approved these changes
Jun 3, 2021
amaury1093
commented
Jun 3, 2021
|
|
||
| // Route implements the LegacyMsg.Type method. | ||
| func (msg MsgGrant) Route() string { | ||
| return sdk.MsgTypeURL(&msg) |
There was a problem hiding this comment.
Authz has no legacy msg handler, so this is dead code. I'm actually inclined to panic here with a user friendly message saying so. wdyt?
|
I'm actually not sure myself about sims. @aleem1314 @atheeshp do simulations also need updating? |
Yes. Small update. protoCdc is not required for legacy messages. |
likhita-809
reviewed
Jun 4, 2021
likhita-809
reviewed
Jun 4, 2021
likhita-809
reviewed
Jun 4, 2021
likhita-809
reviewed
Jun 4, 2021
likhita-809
reviewed
Jun 4, 2021
likhita-809
reviewed
Jun 4, 2021
likhita-809
reviewed
Jun 4, 2021
likhita-809
reviewed
Jun 4, 2021
Co-authored-by: likhita-809 <78951027+likhita-809@users.noreply.github.com>
|
Thanks @likhita-809 for the review! |
likhita-809
approved these changes
Jun 4, 2021
amaury1093
added
the
A:automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #9417
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes