feat!: add error handling to staking hooks

[fedekunze]

Description

• Adds error handling for staking hooks

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title
• added ! to the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• followed the guidelines for building modules
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• included comments for documenting Go code
• updated the relevant documentation or specification
• reviewed "Files changed" and left comments if necessary
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed ! in the type prefix if API or client breaking change
• confirmed all author checklist items have been addressed
• reviewed state machine logic
• reviewed API design and naming
• reviewed documentation is accurate
• reviewed tests and test coverage
• manually tested (if applicable)

[codecov]

Codecov Report

Merging #9571 (1b40966) into master (aef416f) will increase coverage by 0.01%.
The diff coverage is 30.09%.

❗ Current head 1b40966 differs from pull request most recent head 5819d52. Consider uploading reports for the commit 5819d52 to get more accurate results

@@            Coverage Diff             @@
##           master    #9571      +/-   ##
==========================================
+ Coverage   60.59%   60.61%   +0.01%     
==========================================
  Files         588      588              
  Lines       37402    37300     -102     
==========================================
- Hits        22665    22609      -56     
+ Misses      12751    12741      -10     
+ Partials     1986     1950      -36     

Impacted Files	Coverage Δ
simapp/export.go	13.18% <0.00%> (ø)
x/staking/genesis.go	57.89% <0.00%> (-2.11%)	⬇️
x/staking/keeper/msg_server.go	0.43% <0.00%> (-0.01%)	⬇️
x/staking/types/hooks.go	3.22% <0.00%> (-5.87%)	⬇️
x/staking/keeper/delegation.go	69.06% <33.33%> (-1.67%)	⬇️
x/staking/keeper/hooks.go	30.00% <47.36%> (+30.00%)	⬆️
x/distribution/keeper/hooks.go	30.95% <53.84%> (+5.95%)	⬆️
x/slashing/keeper/hooks.go	80.00% <76.92%> (-2.76%)	⬇️
server/logger.go	0.00% <0.00%> (-33.34%)	⬇️
x/bank/keeper/grpc_query.go	40.25% <0.00%> (-10.20%)	⬇️
... and 30 more

[amaury1093]

lgtm. It's unfortunate we didn't think of doing this in the 1st place

[fedekunze]

I see some unrelated tests failing:

    grpc_web_test.go:51: 
        	Error Trace:	grpc_web_test.go:51
        	            				suite.go:118
        	            				grpc_web_test.go:314
        	Error:      	Received unexpected error:
        	            	listen tcp 0.0.0.0:40973: bind: address already in use
        	Test:       	TestGRPCWebTestSuite
coverage: 37.5% of statements
panic: test timed out after 30m0s

[fedekunze]

@AmauryM @aaronc do you think that we could add this functionality for the upcoming v0.43.0 release?

[amaury1093]

@AmauryM @aaronc do you think that we could add this functionality for the upcoming v0.43.0 release?

It's an API-breaking change, I would rahter not include it in 0.43