Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: nil pointer panic on NewIntFromBigInt #9627

Merged
merged 3 commits into from
Jul 5, 2021

Conversation

fedekunze
Copy link
Collaborator

@fedekunze fedekunze commented Jul 3, 2021

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@fedekunze fedekunze changed the title fix: nil pointer panic on NewIntFromBigInt fix: nil pointer panic on NewIntFromBigInt Jul 3, 2021
@codecov
Copy link

codecov bot commented Jul 3, 2021

Codecov Report

Merging #9627 (8736396) into master (57d523d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9627   +/-   ##
=======================================
  Coverage   60.54%   60.55%           
=======================================
  Files         588      588           
  Lines       37447    37449    +2     
=======================================
+ Hits        22674    22676    +2     
  Misses      12781    12781           
  Partials     1992     1992           
Impacted Files Coverage Δ
types/int.go 73.28% <100.00%> (+0.37%) ⬆️

@fedekunze fedekunze requested review from amaury1093 and clevinson July 5, 2021 05:55
@amaury1093
Copy link
Contributor

We dropped support for Launchpad, I propose to remove that backport

@fedekunze fedekunze added the A:automerge Automatically merge PR once all prerequisites pass. label Jul 5, 2021
@alexanderbez alexanderbez merged commit 7f90374 into master Jul 5, 2021
@alexanderbez alexanderbez deleted the fedekunze/big-int-panic branch July 5, 2021 12:36
mergify bot pushed a commit that referenced this pull request Jul 5, 2021
(cherry picked from commit 7f90374)

# Conflicts:
#	CHANGELOG.md
mergify bot pushed a commit that referenced this pull request Jul 5, 2021
(cherry picked from commit 7f90374)

# Conflicts:
#	CHANGELOG.md
@fedekunze fedekunze mentioned this pull request Dec 28, 2021
12 tasks
@tac0turtle
Copy link
Member

@Mergifyio backport release/v0.45.x

@mergify
Copy link
Contributor

mergify bot commented Dec 28, 2021

backport release/v0.45.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Dec 28, 2021
(cherry picked from commit 7f90374)

# Conflicts:
#	CHANGELOG.md
tac0turtle pushed a commit that referenced this pull request Dec 29, 2021
* types: fix nil pointer panic on `NewIntFromBigInt` (#9627)

(cherry picked from commit 7f90374)

# Conflicts:
#	CHANGELOG.md

* fix conflicts

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Aleksandr Bezobchuk <aleks.bezobchuk@gmail.com>
@faddat faddat mentioned this pull request Feb 28, 2022
8 tasks
zakir-code pushed a commit to PundiAI/cosmos-sdk that referenced this pull request Apr 8, 2022
…osmos#10845)

* types: fix nil pointer panic on `NewIntFromBigInt` (cosmos#9627)

(cherry picked from commit 7f90374)

# Conflicts:
#	CHANGELOG.md

* fix conflicts

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Aleksandr Bezobchuk <aleks.bezobchuk@gmail.com>
JimLarson pushed a commit to agoric-labs/cosmos-sdk that referenced this pull request Jul 7, 2022
…osmos#10845)

* types: fix nil pointer panic on `NewIntFromBigInt` (cosmos#9627)

(cherry picked from commit 7f90374)

# Conflicts:
#	CHANGELOG.md

* fix conflicts

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Aleksandr Bezobchuk <aleks.bezobchuk@gmail.com>
JeancarloBarrios pushed a commit to agoric-labs/cosmos-sdk that referenced this pull request Sep 28, 2024
…osmos#10845)

* types: fix nil pointer panic on `NewIntFromBigInt` (cosmos#9627)

(cherry picked from commit 7f90374)

# Conflicts:
#	CHANGELOG.md

* fix conflicts

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Aleksandr Bezobchuk <aleks.bezobchuk@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. T:Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants