Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Added missing validator key save when recovering from mnemonic #9638

Merged
merged 5 commits into from
Jul 6, 2021
Merged

fix: Added missing validator key save when recovering from mnemonic #9638

merged 5 commits into from
Jul 6, 2021

Conversation

leobragaz
Copy link
Contributor

@leobragaz leobragaz commented Jul 6, 2021 •
edited
Loading

This PR adds a missing save inside the InitializeNodeValidatorFilesFromMnemonic method.
Without it when using gaiad init <name> --recover no priv_validator_key.json file is created.

Closes: #XXXX

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@github-actions github-actions bot added the C:x/genutil genutil module issues label Jul 6, 2021
@tac0turtle tac0turtle requested review from amaury1093 and anilcse July 6, 2021 09:08
@tac0turtle tac0turtle changed the title Added missing validator key save when recovering from mnemonic feat: Added missing validator key save when recovering from mnemonic Jul 6, 2021
amaury1093
amaury1093 approved these changes Jul 6, 2021
View reviewed changes
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK.

Could you add a changelog entry?

x/genutil/utils.go Show resolved Hide resolved
@amaury1093 amaury1093 changed the title feat: Added missing validator key save when recovering from mnemonic fix: Added missing validator key save when recovering from mnemonic Jul 6, 2021
@codecov
Copy link

codecov bot commented Jul 6, 2021 •
edited
Loading

Codecov Report

Merging #9638 (321d783) into master (cd22168) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9638   +/-   ##
=======================================
  Coverage   63.54%   63.54%           
=======================================
  Files         570      570           
  Lines       37473    37474    +1     
=======================================
+ Hits        23811    23812    +1     
  Misses      11803    11803           
  Partials     1859     1859
Impacted Files Coverage Δ
x/genutil/utils.go 58.97% <100.00%> (+1.07%) ⬆️

alexanderbez
alexanderbez approved these changes Jul 6, 2021
View reviewed changes
x/genutil/utils.go Show resolved Hide resolved
alexanderbez and others added 2 commits July 6, 2021 08:18
@alexanderbez
Merge branch 'master' into leonardo/validator-private-key-save
0c5eaf9
@leobragaz
fixed docs function name
04a49db 
added test to be sure the generated key is save in a file and it's correct
added CHANGELOG.md entry
@leobragaz leobragaz requested a review from amaury1093 July 6, 2021 13:13
amaury1093
amaury1093 approved these changes Jul 6, 2021
View reviewed changes
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

x/genutil/utils_test.go Outdated Show resolved Hide resolved
@amaury1093 amaury1093 added the A:automerge Automatically merge PR once all prerequisites pass. label Jul 6, 2021
@mergify mergify bot merged commit 0dbc5de into cosmos:master Jul 6, 2021
RiccardoM pushed a commit to desmos-labs/cosmos-sdk that referenced this pull request Aug 26, 2021
@leobragaz @RiccardoM
fix: Added missing validator key save when recovering from mnemonic (c…
864fc99 
…osmos#9638)

(cherry picked from commit 0dbc5de)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tac0turtle tac0turtle tac0turtle approved these changes

@alexanderbez alexanderbez alexanderbez approved these changes

@anilcse anilcse anilcse approved these changes

@amaury1093 amaury1093 amaury1093 approved these changes

@aaronc aaronc Awaiting requested review from aaronc

Assignees
No one assigned
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:x/genutil genutil module issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@leobragaz @amaury1093 @anilcse @alexanderbez @tac0turtle