-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix!: update gentx val pub key input parsing #9827
Conversation
Visit https://dashboard.github.orijtech.com?pr=9827&repo=cosmos%2Fcosmos-sdk to see benchmark details. |
@AmauryM should this also be targeted against an 0.43rc branch? I'm not up to speed on the latest release workflow. |
Codecov Report
@@ Coverage Diff @@
## master #9827 +/- ##
==========================================
+ Coverage 63.47% 63.54% +0.06%
==========================================
Files 566 566
Lines 53107 53130 +23
==========================================
+ Hits 33711 33760 +49
+ Misses 17488 17462 -26
Partials 1908 1908
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense to me
Yes, I think it'll be good. I added the backport label |
(cherry picked from commit cbac7fc) # Conflicts: # CHANGELOG.md
Description
tx staking create-validator
andgentx
, i.e the correct input is the full JSON payload of the public key. e.g.{"@type":"/cosmos.crypto.ed25519.PubKey","key":"<base64 payload>"}
closes: #9819
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change