feat: ADR-040: Implement BadgerDB backend #9848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As this depends on #9573, I'm making it a draft for now and will rebase when that is merged. Also, not sure if more documentation is needed beyond godoc comments. |
roysc
force-pushed
the
roysc/adr-040-db-badger
branch
4 times, most recently
from
83a1c60 to
4d24407
Compare
tac0turtle
requested review from
alexanderbez,
anilcse,
fedekunze and
robert-zaremba
|
@roysc can this be rebased. Then we can begin reviewing |
roysc
force-pushed
the
roysc/adr-040-db-badger
branch
from
dabc06f to
6304cc9
Compare
|
Rebased and ready for review |
8 tasks
alexanderbez
reviewed
Sep 9, 2021
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
save more versions, fewer values
|
Along with review follow-ups, I fixed the version manager initialization so it's not dependent on ordered input, and updated a test case to verify its behavior. |
alexanderbez
approved these changes
Sep 10, 2021
tac0turtle
added
A:automerge
|
@roysc could you update to master, this will allow the bot to merge the PR |
|
We can merge this, yes? |
|
Visit https://dashboard.github.orijtech.com?back=0&pr=9848&remote=false&repo=cosmos%2Fcosmos-sdk to see benchmark details. |
Closed
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Partially resolves: vulcanize#14
Implements a BadgerDB-based backend for the DB interface introduced by #9573 and specified by ADR-040. This uses Badger's "managed" mode for version management, and supports optimistically concurrent transactions (required one patch upstream to fix handling of write conflicts).
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change