Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Introduce Cosmos Scalars #9933

Merged
merged 41 commits into from
Sep 21, 2021
Merged

feat: Introduce Cosmos Scalars #9933

merged 41 commits into from
Sep 21, 2021

Conversation

cyberbono3
Copy link
Contributor

@cyberbono3 cyberbono3 commented Aug 13, 2021 •
edited
Loading

Description

Closes: #9694

goes hand-in-hand with cosmos/cosmos-proto#17

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@cyberbono3 cyberbono3 force-pushed the cyberbono3/introduce-cosmos-scalars branch from 8c98580 to 88234b1 Compare August 13, 2021 15:54
@cyberbono3 cyberbono3 force-pushed the cyberbono3/introduce-cosmos-scalars branch from 88234b1 to 2a846b9 Compare August 13, 2021 15:56
@cyberbono3 cyberbono3 requested a review from amaury1093 August 13, 2021 16:16
@cyberbono3 cyberbono3 force-pushed the cyberbono3/introduce-cosmos-scalars branch from 5bd5402 to 9264d4f Compare August 16, 2021 13:57
@cyberbono3 cyberbono3 changed the title Introduce Cosmos Scalars feat!: Introduce Cosmos Scalars Aug 16, 2021
amaury1093
amaury1093 reviewed Aug 16, 2021
View reviewed changes
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed a couple of files, lgtm overall

proto/cosmos/base/query/v1beta1/pagination.proto Outdated Show resolved Hide resolved
proto/cosmos/tx/v1beta1/tx.proto Outdated Show resolved Hide resolved
proto/cosmos/group/v1beta1/types.proto Outdated Show resolved Hide resolved
proto/cosmos/gov/v1beta1/query.proto Outdated Show resolved Hide resolved
@cyberbono3 cyberbono3 force-pushed the cyberbono3/introduce-cosmos-scalars branch from 54bc0e8 to e4bd120 Compare August 17, 2021 12:06
@orijbot
Copy link

orijbot commented Aug 17, 2021

Visit https://dashboard.github.orijtech.com?pr=9933&remote=false&repo=cosmos%2Fcosmos-sdk to see benchmark details.

@cyberbono3 cyberbono3 marked this pull request as ready for review August 17, 2021 14:07
@cyberbono3
Copy link
Contributor Author

The build fails because there's no generated go code for cosmos.proto. I generated it cosmos/cosmos-proto#22, let's wait for that PR and update go.mod here.

Updated go.mod, make test-all works properly now.

@cyberbono3
Copy link
Contributor Author

Should I add changelog entry ?

@amaury1093
Copy link
Contributor

Should I add changelog entry ?

Yes, that'd be nice

@cyberbono3 cyberbono3 force-pushed the cyberbono3/introduce-cosmos-scalars branch from 1a82d72 to 41f81de Compare September 18, 2021 12:13
amaury1093
amaury1093 approved these changes Sep 20, 2021
View reviewed changes
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

third_party/proto/cosmos_proto/cosmos.proto Show resolved Hide resolved
scripts/protocgen.sh Outdated Show resolved Hide resolved
cyberbono3 and others added 2 commits September 20, 2021 14:57
@cyberbono3 @amaury1093
Update scripts/protocgen.sh
aa7e529 
Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
@cyberbono3
add comments to cosmos.proto
c421312
@cyberbono3
Copy link
Contributor Author

@atheeshp can you take a look, please?

atheeshp
atheeshp reviewed Sep 21, 2021
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Sep 21, 2021 •
edited
Loading

Codecov Report

Merging #9933 (07303ab) into master (6cbbd6d) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 07303ab differs from pull request most recent head 193c335. Consider uploading reports for the commit 193c335 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9933   +/-   ##
=======================================
  Coverage   63.72%   63.72%           
=======================================
  Files         573      573           
  Lines       53766    53766           
=======================================
+ Hits        34263    34264    +1     
+ Misses      17555    17554    -1     
  Partials     1948     1948
Impacted Files Coverage Δ
crypto/keys/internal/ecdsa/privkey.go 84.21% <0.00%> (+1.75%) ⬆️

amaury1093 and others added 2 commits September 21, 2021 11:36
@amaury1093 @atheeshp
Update CHANGELOG.md
d1ed91c 
Co-authored-by: atheeshp <59333759+atheeshp@users.noreply.github.com>
@amaury1093
Merge branch 'master' into cyberbono3/introduce-cosmos-scalars
193c335
@amaury1093 amaury1093 added the A:automerge Automatically merge PR once all prerequisites pass. label Sep 21, 2021
@mergify mergify bot merged commit 94377f1 into master Sep 21, 2021
@mergify mergify bot deleted the cyberbono3/introduce-cosmos-scalars branch September 21, 2021 09:46
@odeke-em
Copy link
Collaborator

@cyberbono3 @AmauryM seems like this PR got merged with compile time failures per https://dashboard.github.orijtech.com/benchmark/4eb8d091a0c44a55a4551a43ef02ca81
image

@amaury1093
Copy link
Contributor

Ah interesting, the SDK's own CI passed. Can I reproduce this locally?

@odeke-em
Copy link
Collaborator

Ah interesting, the SDK's own CI passed. Can I reproduce this locally?

@AmauryM I am on my phone as it is 4:36AM but if you are close to your computer, please help check :-)

@julienrbrt julienrbrt mentioned this pull request May 6, 2022
Merged
19 tasks
@byte-bandit byte-bandit mentioned this pull request Jan 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronc aaronc aaronc left review comments

@atheeshp atheeshp atheeshp approved these changes

@amaury1093 amaury1093 amaury1093 approved these changes

@technicallyty technicallyty Awaiting requested review from technicallyty

@fdymylja fdymylja Awaiting requested review from fdymylja

@alexanderbez alexanderbez Awaiting requested review from alexanderbez

@clevinson clevinson Awaiting requested review from clevinson

Assignees

@clevinson clevinson

@amaury1093 amaury1093

@atheeshp atheeshp

Labels
A:automerge Automatically merge PR once all prerequisites pass. C:CLI C:x/auth C:x/authz C:x/bank C:x/crisis C:x/distribution distribution module related C:x/evidence C:x/feegrant C:x/gov C:x/mint C:x/slashing C:x/staking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cosmos Scalars
7 participants
@cyberbono3 @orijbot @aaronc @amaury1093 @odeke-em @clevinson @atheeshp