NetRPCService service #81
Conversation
* version from config * `listening` and `peerCount` API
|
👍 |
ethereum/api.go
Outdated
| } | ||
|
|
||
| // Listening returns an indication if the node is listening for network connections. | ||
| func (s *NetRPCService) Listening() bool { |
There was a problem hiding this comment.
Let's stick to n *NetRPCService instead of s *NetRPCService
ethereum/api.go
Outdated
| } | ||
|
|
||
| // PeerCount returns the number of connected peers | ||
| func (s *NetRPCService) PeerCount() hexutil.Uint { |
There was a problem hiding this comment.
Let's stick to n *NetRPCService instead of s *NetRPCService
There was a problem hiding this comment.
Is there a reason why you want to return 0 here, because it appears that we aren't using the function anywhere, so why not just remove it?
There was a problem hiding this comment.
Its to expose it over the RPC. Do we know of any tool that requires it, like truffle needed Version ? I think it makes sense to just let it be 0, since we aren't connected ever to any eth peers.
So this looks good, but let's be consistent with n * vs s * in the receiver
There was a problem hiding this comment.
I used s * as service.
|
fixed |
NetRPCService service:
--networkid)listeningandpeerCountAPIIssue: #74