This repository has been archived by the owner on Nov 30, 2021. It is now read-only.
fix csdb index error #493
Merged
fix csdb index error #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## evm-params #493 +/- ##
==============================================
- Coverage 71.33% 71.15% -0.18%
==============================================
Files 40 40
Lines 2637 2638 +1
==============================================
- Hits 1881 1877 -4
- Misses 621 625 +4
- Partials 135 136 +1
Continue to review full report at Codecov.
|
fedekunze
reviewed
Sep 1, 2020
x/evm/types/statedb.go
Outdated
| } | ||
| } | ||
|
|
||
| // Above, we don't copy the actual journal. This means that if the copy is | ||
| // copied, the loop above will be a no-op, since the copy's journal is empty. | ||
| // Thus, here we iterate over stateObjects, to enable copies of copies. | ||
| for addr := range csdb.stateObjectsDirty { | ||
| if idx, exist := state.addressToObjectIndex[addr]; !exist { | ||
| if idx, exist := state.addressToObjectIndex[addr]; exist { |
There was a problem hiding this comment.
I think this should be !exist?
There was a problem hiding this comment.
I think so but we are using idx in the line right after, which is bad if it doesn't exist
There was a problem hiding this comment.
fedekunze
reviewed
Sep 1, 2020
| state.stateObjectsDirty[dirty.address] = struct{}{} | ||
| }) | ||
| delete(state.stateObjectsDirty, dirty.address) | ||
| state.addressToObjectIndex[dirty.address] = len(state.stateObjects) - 1 |
There was a problem hiding this comment.
unfortunately not, the fix seemed to be idx < len(csdb.stateObjects) inside getStateObject and setStateObject which I don't really like...
fedekunze
approved these changes
Sep 1, 2020
fedekunze
added a commit
that referenced
this pull request
Sep 2, 2020
* evm: params * setup * bump commit * fixes * increase gas usage * tests * evm denom param * more config updates * update genesis * update ante handler * csdb param test * more tests and fixes * update statedb.Copy * lint * additional test * fix importer tests * fix AnteHandler test * minor update * revert * undo gas update * stringer test * changelog * fix csdb index error (#493) * attempt to fix * cleanup * add idx check * update csdb.Copy * update default hash * update querier * update rpc tests * fix estimate gas test Co-authored-by: noot <36753753+noot@users.noreply.github.com> Co-authored-by: noot <elizabethjbinks@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #491
Description
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)