Skip to content
This repository has been archived by the owner on Nov 30, 2021. It is now read-only.

types: support eth hex address on accounts #502

Merged
merged 4 commits into from
Sep 8, 2020

Conversation

fedekunze
Copy link
Contributor

Description

ethermintcli q auth account $(ethermintcli keys show mykey -a) -o text
|
  address: eth1f8rqrfwut7ngkxwth0gt99h0lxnxsp09ngvzwl
  eth_address: 0x49c601A5DC5FA68b19CBbbd0b296eFF9a66805e5
  coins:
  - denom: aphoton
    amount: "1000000000000000000"
  - denom: stake
    amount: "999999999900000000"
  public_key: ethpub1pfqnmkepqw45vpsn6dzvm7k22zrghx0nfewjdfacy7wyycv5evfk57kyhwr8cqj5r4x
  account_number: 0
  sequence: 1
  code_hash: c5d2460186f7233c927e7db2dcc703c0e500b653ca82273b7bfad8045d85a470

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Sep 8, 2020

Codecov Report

Merging #502 into development will increase coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #502      +/-   ##
===============================================
+ Coverage        71.72%   71.81%   +0.09%     
===============================================
  Files               40       40              
  Lines             2677     2679       +2     
===============================================
+ Hits              1920     1924       +4     
+ Misses             616      614       -2     
  Partials           141      141              
Impacted Files Coverage Δ
types/account.go 62.16% <100.00%> (+3.82%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3529dd...0195c76. Read the comment docs.

@fedekunze fedekunze marked this pull request as ready for review September 8, 2020 10:59
@fedekunze fedekunze requested a review from noot as a code owner September 8, 2020 10:59
@fedekunze fedekunze merged commit b485542 into development Sep 8, 2020
@fedekunze fedekunze deleted the fedekunze/eth_address branch September 8, 2020 13:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants