This repository has been archived by the owner on Nov 30, 2021. It is now read-only.
update minimum gas price to be 1 #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## development #515 +/- ##
===============================================
- Coverage 72.14% 72.03% -0.11%
===============================================
Files 41 41
Lines 2714 2718 +4
===============================================
Hits 1958 1958
- Misses 613 615 +2
- Partials 143 145 +2
Continue to review full report at Codecov.
|
fedekunze
reviewed
Sep 22, 2020
| @@ -185,8 +189,12 @@ func (msg MsgEthereumTx) Type() string { return TypeMsgEthereumTx } | |||
| // ValidateBasic implements the sdk.Msg interface. It performs basic validation | |||
| // checks of a Transaction. If returns an error if validation fails. | |||
| func (msg MsgEthereumTx) ValidateBasic() error { | |||
| if msg.Data.Price.Cmp(big.NewInt(0)) == 0 { | |||
There was a problem hiding this comment.
nit, we should add a unit test case
| @@ -82,8 +82,12 @@ func (msg MsgEthermint) GetSignBytes() []byte { | |||
|
|
|||
| // ValidateBasic runs stateless checks on the message | |||
| func (msg MsgEthermint) ValidateBasic() error { | |||
| if msg.Price.IsZero() { | |||
|
@fedekunze the main reason for this PR was to prepare for a public testnet, since if txs with gasPrice = 0 are accepted, then transactions are free and the network can be spammed. will add some unit tests! |
11 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
Description
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)