-
Notifications
You must be signed in to change notification settings - Fork 160
Roll back CommitStateDB after failing to execute handler in evm module #677
Conversation
It's ok for me to use this as a short term approach. I think we might want to set everything to store instead of keeping "dirty" arrays/maps. This would be a large refactor of the evm module but it also will increase the performance as we won't need to iterate over the dirty entries during |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @summerpro! Could you add a test case to ensure this is not broken in the future?
Yes, I agree with you, the refactored solution should be able to solve #667 #668 #669 |
You're welcome. Ok i will add it tomorrow |
d7143b5
to
4989c3e
Compare
@fedekunze Can this pr be merged? |
Closes: #668 #669
Description
For contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerFor admin use:
WIP
,R4R
,docs
, etc)