Skip to content
This repository has been archived by the owner on Nov 30, 2021. It is now read-only.

fix bad-data-bug with multi msgs in module evm #694

Closed
wants to merge 11 commits into from

Conversation

summerpro
Copy link
Contributor

Closes: #667

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@summerpro
Copy link
Contributor Author

summerpro commented Jan 9, 2021

this pr can solve #667

app/ante/ante.go Outdated Show resolved Hide resolved
@summerpro summerpro requested a review from fedekunze January 14, 2021 10:09
@summerpro
Copy link
Contributor Author

@fedekunze can this pr be merged?

@summerpro
Copy link
Contributor Author

@fedekunze hi, this solution is indeed quite temporary. I think you may be thinking of refactoring "CommitStateDB" to solve this problem in the future. Am I right?

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days-before-close if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale stale PRs that will be closed if no further action occurs label Mar 19, 2021
@github-actions github-actions bot closed this Mar 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
stale stale PRs that will be closed if no further action occurs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

There may be bad data points in CommitStateDB when exec evm transaction with multi msgs
3 participants