Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing setup context decorator #1025

Conversation

jhernandezb
Copy link
Contributor

Closes: #XXX

Description

Custom ante handler is missing context decorator that sets the gas meter.


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Oct 17, 2021

Codecov Report

Merging #1025 (d6db2e2) into main (f5ee472) will decrease coverage by 1.64%.
The diff coverage is 0.00%.

❗ Current head d6db2e2 differs from pull request most recent head 30e798d. Consider uploading reports for the commit 30e798d to get more accurate results

@@            Coverage Diff             @@
##             main    #1025      +/-   ##
==========================================
- Coverage   12.08%   10.43%   -1.65%     
==========================================
  Files           9       11       +2     
  Lines         927     1083     +156     
==========================================
+ Hits          112      113       +1     
- Misses        810      965     +155     
  Partials        5        5              

@jhernandezb jhernandezb force-pushed the fix/missing-setup-context-decorator branch from d6db2e2 to 30e798d Compare November 9, 2021 10:52
@okwme
Copy link
Contributor

okwme commented Nov 16, 2021

Thanks for this PR @jhernandezb !
These changes have already been incorporated so I'm closing this PR.

@okwme okwme closed this Nov 16, 2021
@jhernandezb
Copy link
Contributor Author

@okwme I don't see it committed to main or any vega RC, maybe I'm missing something

@okwme
Copy link
Contributor

okwme commented Nov 24, 2021

god you're totally right!
i'm sorry about that and appreciate you getting our attention again before the final release.
I've made a new PR: #1078

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants