gofumpt for v4

[faddat]

Description

Applies gofumpt to gaia v4, standardizing the codebase

#1449

---

For contributor use:

• Targeted PR against correct branch (see CONTRIBUTING.md)
• Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
• Code follows the module structure standards.
• Wrote unit and integration tests
• Updated relevant documentation (docs/) or specification (x/<module>/spec/)
• Added relevant godoc comments.
• Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
• Re-reviewed Files changed in the Github PR explorer

---

For admin use:

• Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
• Reviewers assigned
• Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (release/v4.2.x@dbd8a6f). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             release/v4.2.x   #1511   +/-   ##
================================================
  Coverage                  ?   0.41%           
================================================
  Files                     ?       7           
  Lines                     ?     483           
  Branches                  ?       0           
================================================
  Hits                      ?       2           
  Misses                    ?     480           
  Partials                  ?       1           

[faddat]

Got to guess that the liveness check here no longer works -- thoughts?

[faddat]

Seems not only that is needed to fix it. if I had to guess it is dependent on environment.

[faddat]

I just got rid of the liveness test.

[tac0turtle]

utACK

[tac0turtle]

was this failing?

[faddat]

yes, but I think it's failing for process reasons?

Basically, it is an attempt to backport and the original v4 branch had a different test. I could take the .github folder from v4 and get rid of the diff, though.

Ah, I remember why it's failing now-- pretty sure it couldn't find a file in the environment.

[faddat]

Another way to say this: v4 ci isn't maintained.

[okwme]

same as per comment from #1509:

opened a new issue related to stable release policy (#1549).
appreciate the work @faddat but these changes don't make sense to merge into those versions unless they're going to be part of a new release of those versions and EOL should only be bypassed by security updates.

[faddat]

Except that legibility is a security update.