use distroless.dev/static base image #1648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirbyquerby
requested review from
okwme,
alexanderbez,
zmanian,
yaruwangway,
jgimeno,
crodriguezvega,
cmwaters,
jackzampolin,
mmulji-ic and
glnro
as code owners
Merged
Codecov Report
@@ Coverage Diff @@
## main #1648 +/- ##
=======================================
Coverage 47.88% 47.88%
=======================================
Files 10 10
Lines 1489 1489
=======================================
Hits 713 713
Misses 755 755
Partials 21 21 |
|
thanks @kirbyquerby ! |
|
The lint errors were in files I didn't touch :'( |
mmulji-ic
approved these changes
Aug 10, 2022
|
Thanks @kirbyquerby @odeke-em |
mmulji-ic
added a commit
that referenced
this pull request
Oct 5, 2022
* use distroless.dev/static base image (#1648) * closes #1621 * run hermes commands as root (cherry picked from commit e011a10) # Conflicts: # Dockerfile # tests/e2e/e2e_test.go # tests/e2e/e2e_util_test.go * Fix merge conflicts * Set the version of Hermes to 0.12.0 * Resolved conflict with codeowners Co-authored-by: Nathan Dias <kirbyquerby@users.noreply.github.com> Co-authored-by: Milan Mulji <98309852+mmulji-ic@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is a redo of #1628 with fixes for the failed tests in #1625 . Specifically, the hermes container still runs as
root, so commands need to be sent to it asrootrather thannonroot.Updates #1621
/cc @okwme @odeke-em