-
Notifications
You must be signed in to change notification settings - Fork 722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix ICS equivocation proposal #2197
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sainoe
requested review from
alexanderbez,
zmanian,
yaruwangway,
crodriguezvega,
jackzampolin,
mmulji-ic,
glnro,
jtremback,
mpoke,
MSalopek and
shaspitz
as code owners
February 15, 2023 16:04
shaspitz
approved these changes
Feb 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hell yea!
glnro
approved these changes
Feb 15, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2197 +/- ##
==========================================
+ Coverage 84.75% 84.76% +0.01%
==========================================
Files 21 21
Lines 1482 1483 +1
==========================================
+ Hits 1256 1257 +1
Misses 181 181
Partials 45 45
|
MSalopek
approved these changes
Feb 15, 2023
mergify bot
pushed a commit
that referenced
this pull request
Feb 15, 2023
* replace sdk with Shawn's fork * fix equivocation bug on ICS * clean go mod (cherry picked from commit d943cc3)
shaspitz
pushed a commit
that referenced
this pull request
Feb 15, 2023
shaspitz
pushed a commit
that referenced
this pull request
Feb 15, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the keepers ordering in app/keepers so that the
ProviderKeeper
is created after theEvidenceKeeper
.