Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ICS equivocation proposal #2197

Merged
merged 3 commits into from
Feb 15, 2023
Merged

fix ICS equivocation proposal #2197

merged 3 commits into from
Feb 15, 2023

Conversation

sainoe
Copy link
Contributor

@sainoe sainoe commented Feb 15, 2023

Update the keepers ordering in app/keepers so that the ProviderKeeper is created after the EvidenceKeeper.

Copy link
Contributor

@shaspitz shaspitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hell yea!

@codecov
Copy link

codecov bot commented Feb 15, 2023

Codecov Report

Merging #2197 (138522b) into main (2aa78a5) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2197      +/-   ##
==========================================
+ Coverage   84.75%   84.76%   +0.01%     
==========================================
  Files          21       21              
  Lines        1482     1483       +1     
==========================================
+ Hits         1256     1257       +1     
  Misses        181      181              
  Partials       45       45              
Impacted Files Coverage Δ
app/keepers/keepers.go 98.91% <100.00%> (+<0.01%) ⬆️

@sainoe sainoe merged commit d943cc3 into main Feb 15, 2023
@sainoe sainoe deleted the sainoe/evidence-debug branch February 15, 2023 16:23
mergify bot pushed a commit that referenced this pull request Feb 15, 2023
* replace sdk with Shawn's fork

* fix equivocation bug on ICS

* clean go mod

(cherry picked from commit d943cc3)
shaspitz pushed a commit that referenced this pull request Feb 15, 2023
* replace sdk with Shawn's fork

* fix equivocation bug on ICS

* clean go mod

(cherry picked from commit d943cc3)

Co-authored-by: Simon Noetzlin <simon.ntz@gmail.com>
shaspitz pushed a commit that referenced this pull request Feb 15, 2023
* replace sdk with Shawn's fork

* fix equivocation bug on ICS

* clean go mod

(cherry picked from commit d943cc3)

Co-authored-by: Simon Noetzlin <simon.ntz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants