test: parsing result of query hermes pending packets

[yaruwangway]

closes: #2486

Description

hermesPendingPackets will get the pending packets result:

SUCCESS Summary {
    src: PendingPackets {
        unreceived_packets: [],
        unreceived_acks: [],
    },
    dst: PendingPackets {
        unreceived_packets: [],
        unreceived_acks: [],
    },
}

In order to check if there is pending packets, the '\n' and ' ' are removed from result.
pending packet: SUCCESSSummary{src:PendingPackets{unreceived_packets:[],unreceived_packets:[],},dst:PendingPackets{unreceived_packets:[],unreceived_packets:[],},}

If the result contains substr "src:Pendingpackets{unreceived_packets:[]", there is not pending packets. In order to not worry about the casing, we can convert the result to all lower case.

The failure of the e2e test is from looking for the wrong substring(wrong casing): "src:pendingPackets{unreceived_packets:[]" in the query result.
hermesPendingPackets with --json will get json

{"result":{"dst":{"unreceived_acks":[],"unreceived_packets":[]},"src":{"unreceived_acks":[],"unreceived_packets":[]}},"status":"success"}

update executeHermesCommand with adding --json and parsing the json result to get unreceived_packets: []

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• Included the correct type prefix in the PR title
• Added ! to the type prefix if API or client breaking change
• Targeted the correct branch (see PR Targeting)
• Provided a link to the relevant issue or specification
• Followed the guidelines for building SDK modules
• Included the necessary unit and integration tests
• Added a changelog entry to CHANGELOG.md
• Included comments for documenting Go code
• Updated the relevant documentation or specification
• Reviewed "Files changed" and left comments if necessary
• Confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed ! in the type prefix if API or client breaking change
• confirmed all author checklist items have been addressed
• reviewed state machine logic
• reviewed API design and naming
• reviewed documentation is accurate
• reviewed tests and test coverage

[sainoe]

As a suggestion for future refactoring: Hermes provides a --json flag making it way easier to parse its output :).

[yaruwangway]

As a suggestion for future refactoring: Hermes provides a --json flag making it way easier to parse its output :).

Hi, how to use it, just add "--json" when query, i tried, not working.

hermes --config config-zero.toml query packet pending --chain test-ibc --channel channel-0 --port transfer --json
error: Found argument '--json' which wasn't expected, or isn't valid in this context

	If you tried to supply `--json` as a value rather than a flag, use `-- --json`

[mmulji-ic]

the strings.Contains function is case sensitive, so reporting like 'Error', 'error', won't give you the result that you expected. Its more defensive to make everything a certain case, and then check.

[sainoe]

Agree, this relayer output should also be parsed using JSON.

[yaruwangway]

it is not possible to be parsed in json, the stderr looks like :

2023-06-09T09:07:53.349739Z  INFO ThreadId(01) PacketRecvCmd{src_chain=chain-3Yoz03 src_port=transfer src_channel=channel-0 dst_chain=chain-c0lUEe}: unreceived packets found: 1
2023-06-09T09:07:53.362954Z  INFO ThreadId(01) PacketRecvCmd{src_chain=chain-3Yoz03 src_port=transfer src_channel=channel-0 dst_chain=chain-c0lUEe}: pulled packet data for 1 events; events_total=1 events_left=0
2023-06-09T09:07:53.697419Z  INFO ThreadId(01) PacketRecvCmd{src_chain=chain-3Yoz03 src_port=transfer src_channel=channel-0 dst_chain=chain-c0lUEe}:relay{odata=packet-recv ->Source @0-176; len=1}: assembled batch of 2 message(s)
2023-06-09T09:07:53.743368Z ERROR ThreadId(07) send_tx_with_account_sequence_retry{id=chain-3Yoz03}: broadcast_tx_sync: Response { code: Err(13), data: Data([]), log: Log("Insufficient fees; got: 0uatom required: 2uatom: insufficient fee"), hash: transaction::Hash(AF2B36D5298C6E79B233C0E10D8F7316307D47EE28AD231CBE6AFA56010F52D3) }: diagnostic: the price configuration for this chain may be too low! please check the `gas_price.price` Hermes config.toml
2023-06-09T09:07:53.746010Z  INFO ThreadId(07) wait_for_block_commits: waiting for commit of tx hashes(s) AF2B36D5298C6E79B233C0E10D8F7316307D47EE28AD231CBE6AFA56010F52D3 id=chain-3Yoz03
2023-06-09T09:07:53.746997Z  INFO ThreadId(01) PacketRecvCmd{src_chain=chain-3Yoz03 src_port=transfer src_channel=channel-0 dst_chain=chain-c0lUEe}:relay{odata=packet-recv ->Source @0-176; len=1}: [Sync->chain-3Yoz03] result events:
	ChainErrorEv(check_tx (broadcast_tx_sync) on chain chain-3Yoz03 for Tx hash AF2B36D5298C6E79B233C0E10D8F7316307D47EE28AD231CBE6AFA56010F52D3 reports error: code=Err(13), log=Log("Insufficient fees; got: 0uatom required: 2uatom: insufficient fee"))
	ChainErrorEv(check_tx (broadcast_tx_sync) on chain chain-3Yoz03 for Tx hash AF2B36D5298C6E79B233C0E10D8F7316307D47EE28AD231CBE6AFA56010F52D3 reports error: code=Err(13), log=Log("Insufficient fees; got: 0uatom required: 2uatom: insufficient fee"))
	```

[mmulji-ic]

This is what I was suggesting, making this lower-case:

strings.Contains(strings.ToLower(string(stdout)) , "error")

... and check against 'error'

[mmulji-ic]

Why change from string to bytes here? You have a string comparison later on.

[yaruwangway]

this is for unmarshal json from byte, otherwise, unmarshal has to convert string to byte

[sainoe]

Would rename this type to sthg more self-explantory like RelayerPacketsOutput.

[mmulji-ic]

Same comment as above.