Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to latest sdk #52

Merged
merged 4 commits into from
Jun 24, 2019
Merged

upgrade to latest sdk #52

merged 4 commits into from
Jun 24, 2019

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Jun 21, 2019

As per changes introduced with cosmos/cosmos-sdk#4602

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added a relevant changelog entry: clog add [section] [stanza] [message]
  • Reviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge PR #XYZ: [title]" (coding standards)

@codecov-io
Copy link

Codecov Report

Merging #52 into master will increase coverage by 0.43%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #52      +/-   ##
==========================================
+ Coverage   66.88%   67.31%   +0.43%     
==========================================
  Files           5        5              
  Lines         465      465              
==========================================
+ Hits          311      313       +2     
+ Misses        123      121       -2     
  Partials       31       31

@alessio alessio changed the title Testing cosmos/cosmos-sdk#4602 upgrade to latest sdk Jun 22, 2019
@alessio alessio marked this pull request as ready for review June 22, 2019 12:06
@alessio alessio requested review from fedekunze and sabau June 22, 2019 12:06
@alessio alessio merged commit 0c12cce into master Jun 24, 2019
@alessio alessio deleted the alessio/update-against-sdk-4602 branch June 24, 2019 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants