Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the denom metadata for the cosmoshub in the stargate migration #564

Merged
merged 3 commits into from
Jan 25, 2021

Conversation

zmanian
Copy link
Member

@zmanian zmanian commented Jan 23, 2021

Set the Cosmos Hub ATOM metadata as required by
cosmos/cosmos-sdk#8417


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Jan 23, 2021

Codecov Report

Merging #564 (55c5f14) into main (1a98272) will decrease coverage by 0.21%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #564      +/-   ##
==========================================
- Coverage   11.58%   11.37%   -0.22%     
==========================================
  Files           8        8              
  Lines         673      686      +13     
==========================================
  Hits           78       78              
- Misses        586      599      +13     
  Partials        9        9              

app/migrate.go Outdated Show resolved Hide resolved
@fedekunze fedekunze merged commit 7756f45 into main Jan 25, 2021
@fedekunze fedekunze deleted the zaki-set-denom-metadata-migration branch January 25, 2021 11:41
shahankhatch pushed a commit that referenced this pull request Jan 25, 2021
)

* Set the denom metadata for the cosmoshub in the stargate migration

* Update app/migrate.go

* changelog

Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Federico Kunze <federico.kunze94@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants