Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update gaia build to go1.16 #838

Merged
merged 3 commits into from
Apr 29, 2021
Merged

Update gaia build to go1.16 #838

merged 3 commits into from
Apr 29, 2021

Conversation

shahankhatch
Copy link
Contributor

Closes #836

@shahankhatch shahankhatch added scope: build Changes, features and bugs related the build process. sim labels Apr 28, 2021
@codecov
Copy link

codecov bot commented Apr 28, 2021 •
edited
Loading

Codecov Report

Merging #838 (a0f3024) into main (8bc3a8f) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main    #838   +/-   ##
=====================================
  Coverage   0.41%   0.41%           
=====================================
  Files          7       7           
  Lines        483     483           
=====================================
  Hits           2       2           
  Misses       480     480           
  Partials       1       1

@shahankhatch shahankhatch added sim and removed sim labels Apr 28, 2021
@shahankhatch
Copy link
Contributor Author

Need to alter sim label criteria in order to run long-running sim against this PR

@shahankhatch shahankhatch added sim and removed sim labels Apr 28, 2021
@shahankhatch
Copy link
Contributor Author

shahankhatch commented Apr 29, 2021 •
edited
Loading

SimLabeled / test-sim-nondeterminism-labeled is now running. Will be RFR as soon as all checks pass, SimLabeled / test-sim-nondeterminism-labeled in particular.

alessio
alessio reviewed Apr 29, 2021
View reviewed changes
go.mod Show resolved Hide resolved
@shahankhatch shahankhatch merged commit 09f9d8d into main Apr 29, 2021
@shahankhatch shahankhatch deleted the shahan/update_to_go1.16 branch April 29, 2021 15:04
@shahankhatch shahankhatch linked an issue May 11, 2021 that may be closed by this pull request
Consider migrating build to go1.16 #812
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alessio alessio alessio approved these changes

@alexanderbez alexanderbez Awaiting requested review from alexanderbez

@jgimeno jgimeno Awaiting requested review from jgimeno

@zmanian zmanian Awaiting requested review from zmanian zmanian is a code owner

@toschdev toschdev Awaiting requested review from toschdev

Assignees
No one assigned
Labels
scope: build Changes, features and bugs related the build process.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update build to use go 1.16 Consider migrating build to go1.16
2 participants
@shahankhatch @alessio