Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for keys parse bug #884

Merged
merged 2 commits into from
Jun 25, 2021
Merged

Fix for keys parse bug #884

merged 2 commits into from
Jun 25, 2021

Conversation

okwme
Copy link
Contributor

@okwme okwme commented Jun 23, 2021

Closes: #XXX

Description

Fixes gaiad keys parse <input>. Bug reported here and here and PR against Cosmos SDK that demonstrates fix here.

Otherwise the gaiad keys parse <input> command hangs indefinitely.


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

fixes `gaiad keys parse <input>`
@codecov
Copy link

codecov bot commented Jun 23, 2021

Codecov Report

Merging #884 (04d412f) into main (94a30c6) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##            main    #884      +/-   ##
========================================
- Coverage   0.41%   0.39%   -0.02%     
========================================
  Files          7       7              
  Lines        483     505      +22     
========================================
  Hits           2       2              
- Misses       480     502      +22     
  Partials       1       1              

@shahankhatch shahankhatch merged commit 203737f into main Jun 25, 2021
@shahankhatch shahankhatch deleted the okwme-patch-1 branch June 25, 2021 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants