Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go 1.17 #993

Merged
merged 2 commits into from
Sep 29, 2021
Merged

Go 1.17 #993

merged 2 commits into from
Sep 29, 2021

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Sep 28, 2021

Closes: #XXX

Description

Go 1.17 makes go modules easier to read and audit.


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Sep 28, 2021

Codecov Report

Merging #993 (f33926b) into main (2947cb5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #993   +/-   ##
=======================================
  Coverage   10.44%   10.44%           
=======================================
  Files          11       11           
  Lines        1082     1082           
=======================================
  Hits          113      113           
  Misses        964      964           
  Partials        5        5           

@alexanderbez alexanderbez merged commit 913c020 into cosmos:main Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants