Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

github: increase test timeout to 10 minutes #337

Closed
wants to merge 1 commit into from
Closed

github: increase test timeout to 10 minutes #337

wants to merge 1 commit into from

Conversation

erikgrinaker
Copy link
Contributor

See failure in #333.

@erikgrinaker erikgrinaker self-assigned this Nov 23, 2020
@erikgrinaker erikgrinaker changed the title github: bump test timeout github: ncrease test timeout to 10 minutes Nov 23, 2020
@erikgrinaker erikgrinaker changed the title github: ncrease test timeout to 10 minutes github: increase test timeout to 10 minutes Nov 23, 2020
tac0turtle
tac0turtle approved these changes Nov 23, 2020
View reviewed changes
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I saw the error was a data race is this caused by the timeout?

@erikgrinaker
Copy link
Contributor Author

Looks like it. There's one backtrace to the coverage thing, and one hidden one (possibly some internal Go thing). I'm guessing something went wrong while handling the timeout panic.

@tac0turtle
Copy link
Member

It is super odd that this test is running for so long though, is this due to a new change?

@erikgrinaker
Copy link
Contributor Author

erikgrinaker commented Nov 23, 2020 •
edited
Loading

TestRandomOperations sets up a bunch of trees and runs thousands of random operations against each one. When the race detector is enabled, this takes forever.

I'm looking into running them in parallel now, although it may make it harder to read the output since the different tests' output will be jumbled together.

@erikgrinaker
Copy link
Contributor Author

Seems to work well enough, #338. Suggest we just do that instead, and drop this timeout bump.

@erikgrinaker
Copy link
Contributor Author

Superseded by #338.

@tac0turtle tac0turtle deleted the erik/master-test-timeout branch October 11, 2022 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tac0turtle tac0turtle tac0turtle approved these changes

@alexanderbez alexanderbez Awaiting requested review from alexanderbez

Assignees

@erikgrinaker erikgrinaker

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erikgrinaker @tac0turtle