Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data locality #556

Closed
wants to merge 3 commits into from
Closed

Data locality #556

wants to merge 3 commits into from

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Sep 9, 2022

remaking from notional-labs repo.

This PR is for stage 1 of

@faddat faddat requested a review from a team as a code owner September 9, 2022 02:12
@faddat faddat marked this pull request as draft September 9, 2022 02:13
tac0turtle
tac0turtle reviewed Sep 9, 2022
View reviewed changes
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please break out the current changes into their own pr. this work needs to be specific to each pr not conflated with other work

julienrbrt
julienrbrt reviewed Sep 9, 2022
View reviewed changes
Makefile
@@ -114,9 +113,6 @@ tools-clean:
# Non Go tools
###

protoVer=0.10.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be reverted

julienrbrt
julienrbrt reviewed Sep 9, 2022
View reviewed changes
Makefile
@@ -129,5 +125,5 @@ proto-check-breaking:

proto-gen:
@echo "Generating Protobuf files"
$(DOCKER) run --rm -v $(CURDIR):/workspace --workdir /workspace $(protoImageName) sh scripts/protocgen.sh
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

@faddat
Copy link
Contributor Author

faddat commented Sep 9, 2022

thanks!

@faddat
Copy link
Contributor Author

faddat commented Sep 9, 2022

Hey, sorry about that guys. I began this branch from the branch for the earlier pr #554

I'll close and re-open from main.

I'm currently on vacation, but I've asked Tuan (@baabeetaa ) Khanh (catshark) and Vuong to have a look at this over the weekend. BRB with a fresh one.

@faddat faddat closed this Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrbrt julienrbrt julienrbrt left review comments

@tac0turtle tac0turtle tac0turtle left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@faddat @tac0turtle @julienrbrt