feat: speed up rollback command #636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yihuang
force-pushed
the
master
branch
2 times, most recently
from
d9f40d1
to
9c1abd8
Compare
mmsqe
reviewed
Dec 1, 2022
| @@ -605,6 +586,11 @@ func (ndb *nodeDB) deleteNodesFrom(version int64, hash []byte) error { | |||
| return err | |||
| } | |||
|
|
|||
| if node.version < version { | |||
mmsqe
reviewed
Dec 5, 2022
yihuang
requested review from
cool-develope and
mmsqe
and removed request for
cool-develope and
mmsqe
- fully rebuild fast node indexes after rollback, rather than leave it in dirty state. - skip unnecessary subtree traversal when deleting the latest version. - restrict the iteration range when deleting orphans.
tac0turtle
reviewed
Dec 12, 2022
| if err != nil { | ||
| return err | ||
| } | ||
| // NOTICE: we don't touch fast node indexes here, because it'll be rebuilt later because of version mismatch. |
There was a problem hiding this comment.
I believe the previous logic to just delete some fastnodes is simply wrong, because fast node is assumed to be represent the complete live state, it's wrong to leave a partial fast node index.
In new version, fast node index will be fully rebuilt because of version mismatch, and if user don't want to slow down rollback, they can disable fast node index before rollback, after recovered the node operation, user can find another good time to rebuild the fast node index by enable it again.
tac0turtle
approved these changes
Dec 12, 2022
I hope so, it's a big UX improvement for existing version. |
|
@Mergifyio backport release/v0.19.x |
mergify bot
pushed a commit
that referenced
this pull request
Dec 12, 2022
(cherry picked from commit d4086fe) # Conflicts: # nodedb.go
✅ Backports have been created
|
tac0turtle
added a commit
that referenced
this pull request
Dec 26, 2022
ankurdotb
pushed a commit
to cheqd/iavl
that referenced
this pull request
Feb 28, 2023
Co-authored-by: yihuang <huang@crypto.com> Co-authored-by: Marko Baricevic <marbar3778@yahoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support LazyLoadVersion, remove lazy support, we might be able to use lazy mode by defaultA cleaner version based on: #636
Test result:
Combined with the lazy loading option, disabling fastnode, rollback takes
1.8son one of our testnet archive node(337G), previously it was several hours.