Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add API TraverseStateChanges to extract state changes from iavl versions #654

Merged
merged 9 commits into from
Jan 10, 2023
Merged

feat: Add API TraverseStateChanges to extract state changes from iavl versions #654

merged 9 commits into from
Jan 10, 2023

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Jan 3, 2023 •
edited
Loading

the diff algorithm is based on: #646

@yihuang yihuang requested a review from a team as a code owner January 3, 2023 11:28
yihuang
yihuang commented Jan 3, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@yihuang yihuang mentioned this pull request Jan 3, 2023
Merged
13 tasks
tac0turtle
tac0turtle reviewed Jan 3, 2023
View reviewed changes
nodedb.go Show resolved Hide resolved
iterator.go Outdated Show resolved Hide resolved
diff.go Outdated Show resolved Hide resolved
@yihuang
Copy link
Collaborator Author

yihuang commented Jan 4, 2023

godoc added, can we backport to 0.19.x? it's an additive feature.

@yihuang yihuang changed the title Add API TraverseStateChanges to extract state changes from iavl versions feat: Add API TraverseStateChanges to extract state changes from iavl versions Jan 4, 2023
@yihuang yihuang mentioned this pull request Jan 4, 2023
Merged
tac0turtle
tac0turtle approved these changes Jan 4, 2023
View reviewed changes
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK. I think its fine to backport

@cool-develope
Copy link
Collaborator

could you provide some covering tests?

@yihuang
Copy link
Collaborator Author

yihuang commented Jan 5, 2023

could you provide some covering tests?

done, added randomized round-trip test case to make sure extracted change set is identical to the original ones.

@tac0turtle tac0turtle merged commit 98e2b0d into cosmos:master Jan 10, 2023
@tac0turtle
Copy link
Member

@Mergifyio backport release/v0.19.0

@yihuang yihuang deleted the dump_changeset_main branch January 10, 2023 09:28
@mergify
Copy link
Contributor

mergify bot commented Jan 10, 2023

backport release/v0.19.0

❌ No backport have been created

  • Backport to branch release/v0.19.0 failed: Branch not found

@yihuang
Copy link
Collaborator Author

yihuang commented Jan 10, 2023

awesome 👍

@yihuang yihuang restored the dump_changeset_main branch January 10, 2023 09:29
@yihuang
Copy link
Collaborator Author

yihuang commented Jan 10, 2023

@Mergifyio backport release/v0.19.0

@yihuang
Copy link
Collaborator Author

yihuang commented Jan 10, 2023

Sorry, I delete the branch too fast.

@mergify
Copy link
Contributor

mergify bot commented Jan 10, 2023 •
edited by tac0turtle
Loading

backport release/v0.19.0

❌ Command disallowed due to command restrictions in the Mergify configuration.

  • sender-permission>=write

@tac0turtle
Copy link
Member

@Mergifyio backport release/v0.19.x

mergify bot pushed a commit that referenced this pull request Jan 10, 2023
@yihuang @mergify
feat: Add API TraverseStateChanges to extract state changes from ia…
d31e92d 
…vl versions (#654)

Co-authored-by: Marko <marbar3778@yahoo.com>
(cherry picked from commit 98e2b0d)
@mergify mergify bot mentioned this pull request Jan 10, 2023
Merged
@mergify
Copy link
Contributor

mergify bot commented Jan 10, 2023

backport release/v0.19.x

✅ Backports have been created

@yihuang yihuang deleted the dump_changeset_main branch January 10, 2023 13:25
tac0turtle added a commit that referenced this pull request Jan 13, 2023
@mergify @yihuang @tac0turtle
feat: Add API TraverseStateChanges to extract state changes from ia…
9f9c2a0 
…vl versions (backport #654) (#657)

Co-authored-by: yihuang <huang@crypto.com>
Co-authored-by: Marko <marbar3778@yahoo.com>
ankurdotb pushed a commit to cheqd/iavl that referenced this pull request Feb 28, 2023
@mergify @yihuang
@tac0turtle @ankurdotb
feat: Add API TraverseStateChanges to extract state changes from ia…
61de78e 
…vl versions (backport cosmos#654) (cosmos#657)

Co-authored-by: yihuang <huang@crypto.com>
Co-authored-by: Marko <marbar3778@yahoo.com>
mmsqe pushed a commit to mmsqe/iavl that referenced this pull request Jun 29, 2023
@yihuang @tac0turtle @mmsqe
feat: Add API TraverseStateChanges to extract state changes from ia…
b3b7040 
…vl versions (cosmos#654)

Co-authored-by: Marko <marbar3778@yahoo.com>
@mmsqe mmsqe mentioned this pull request Jun 29, 2023
Merged
mmsqe pushed a commit to mmsqe/iavl that referenced this pull request Jun 29, 2023
@yihuang @tac0turtle @mmsqe
feat: Add API TraverseStateChanges to extract state changes from ia…
ed05b41 
…vl versions (cosmos#654)

Co-authored-by: Marko <marbar3778@yahoo.com>
tac0turtle added a commit that referenced this pull request Jul 17, 2023
@mmsqe @yihuang @tac0turtle
feat: Add API TraverseStateChanges to extract state changes from ia…
744f87d 
…vl versions (backport: #654)  (#796)

Co-authored-by: yihuang <huang@crypto.com>
Co-authored-by: Marko <marbar3778@yahoo.com>
@coderabbitai coderabbitai bot mentioned this pull request May 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cool-develope cool-develope cool-develope approved these changes

@tac0turtle tac0turtle tac0turtle approved these changes

@facundomedica facundomedica Awaiting requested review from facundomedica

Assignees

@facundomedica facundomedica

@tac0turtle tac0turtle

@cool-develope cool-develope

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yihuang @cool-develope @tac0turtle @facundomedica