Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose nodeDB's DeleteVersionsFrom method #952

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,10 @@
# Changelog

## Unreleased

Comment on lines +3 to +4
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure proper formatting in the changelog.

It's good practice to maintain consistent formatting in changelog entries. Ensure that there are blank lines surrounding major sections for better readability.

## Unreleased
+

Committable suggestion was skipped due to low confidence.

### Improvements

- [#952](https://github.com/cosmos/iavl/pull/952) Add `DeleteVersionsFrom(int64)` API.
- [#961](https://github.com/cosmos/iavl/pull/961) Add new `GetLatestVersion` API to get the latest version.

## v1.2.0 May 13, 2024
Expand Down
10 changes: 10 additions & 0 deletions mutable_tree.go
Original file line number Diff line number Diff line change
Expand Up @@ -873,6 +873,16 @@ func (tree *MutableTree) DeleteVersionsTo(toVersion int64) error {
return tree.ndb.Commit()
}

// DeleteVersionsFrom removes from the given version upwards from the MutableTree.
// It will not block the SaveVersion() call, instead it will be queued and executed deferred.
func (tree *MutableTree) DeleteVersionsFrom(fromVersion int64) error {
if err := tree.ndb.DeleteVersionsFrom(fromVersion); err != nil {
return err
}

return tree.ndb.Commit()
}

// Rotate right and return the new node and orphan.
func (tree *MutableTree) rotateRight(node *Node) (*Node, error) {
var err error
Expand Down
29 changes: 28 additions & 1 deletion mutable_tree_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ func TestNewIteratorConcurrency(t *testing.T) {
}
}

func TestDelete(t *testing.T) {
func TestDeleteVersionsTo(t *testing.T) {
tree := setupMutableTree(false)

_, err := tree.set([]byte("k1"), []byte("Fred"))
Expand All @@ -132,6 +132,33 @@ func TestDelete(t *testing.T) {
require.Equal(t, 0, bytes.Compare([]byte("Fred"), proof.GetExist().Value))
}

func TestDeleteVersionsFrom(t *testing.T) {
tree := setupMutableTree(false)

_, err := tree.set([]byte("k1"), []byte("Wilma"))
require.NoError(t, err)
_, version, err := tree.SaveVersion()
require.NoError(t, err)
_, _, err = tree.SaveVersion()
require.NoError(t, err)
_, _, err = tree.SaveVersion()
require.NoError(t, err)

require.NoError(t, tree.DeleteVersionsFrom(version+1))

proof, err := tree.GetVersionedProof([]byte("k1"), version)
require.Nil(t, err)
require.Equal(t, 0, bytes.Compare([]byte("Wilma"), proof.GetExist().Value))

proof, err = tree.GetVersionedProof([]byte("k1"), version+1)
require.EqualError(t, err, ErrVersionDoesNotExist.Error())
require.Nil(t, proof)

proof, err = tree.GetVersionedProof([]byte("k1"), version+2)
require.EqualError(t, err, ErrVersionDoesNotExist.Error())
require.Nil(t, proof)
}

func TestGetRemove(t *testing.T) {
require := require.New(t)
tree := setupMutableTree(false)
Expand Down