async-icq simapp & demo #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtieri
reviewed
Oct 26, 2023
There was a problem hiding this comment.
I left a bunch of duplicate comments, i was going to point out everywhere that import paths could be updated but quickly realized that there are a ton of them so stopped. I think a find/replace all will turn up all of the locations they can be changed. Sorry about that 😛
Other than the handful of comments i had regarding small things this looks good!
modules/async-icq/testing/demo-simapp/x/interquery/client/cli/query.go
Outdated
Show resolved
Hide resolved
modules/async-icq/testing/demo-simapp/x/interquery/client/cli/query_params.go
Outdated
Show resolved
Hide resolved
modules/async-icq/testing/demo-simapp/x/interquery/client/cli/tx.go
Outdated
Show resolved
Hide resolved
modules/async-icq/testing/demo-simapp/x/interquery/types/types.go
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #112
summary
Adds host simapp & controller module example + CI test for async icq
PR is so large because of the x/ copy paste from the old repo