feat!: icq x/params migration + msg_server #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reecepbcups
changed the title
jtieri
reviewed
Nov 6, 2023
There was a problem hiding this comment.
mostly the same nits from #128 but this looks good, great work @Reecepbcups !!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #87 (2/2)
This should be in v7.1.0 (state breaking!) so v47 chains can upgrade before v50/51 migrations (params is removed in v51, so they HAVE to do this in 47 or 50)
Migration Example: https://github.com/cosmos/ibc-apps/blob/reece/icq-params-migration/modules/async-icq/testing/simapp/upgrades/upgrades.go#L31-L67