Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning to ibc-hooks docs #70

Merged
merged 2 commits into from
Oct 17, 2023
Merged

Add warning to ibc-hooks docs #70

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b9cb85e
docs warning
nicolaslara Jul 25, 2023
195b0ce
Merge branch 'main' into nicolas/ibc-hooks-warning-in-docs
nicolaslara Aug 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions modules/ibc-hooks/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,8 @@ For use with IBC hooks, the message fields above can be derived from the followi
- `Msg`: This field should be directly obtained from the ICS-20 packet metadata.
- `Funds`: This field is set to the amount of funds being sent over in the ICS-20 packet. The denom in the packet must be specified as the counterparty chain's representation of the denom.

> **_WARNING:_** Due to a [bug](https://twitter.com/SCVSecurity/status/1682329758020022272) in the packet forward middleware, we cannot trust the sender from chains that use PFM. Until that is fixed, we recommend chains to not trust the sender on contracts executed via IBC hooks.


The fully constructed execute message will look like the following:

Expand Down