fix closing iterator in 07-tendermint

cosmos · Jan 17, 2023 · 140b79e · 140b79e
1 parent 8f0cfb0
commit 140b79e
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/modules/light-clients/07-tendermint/store.go b/modules/light-clients/07-tendermint/store.go
@@ -80,7 +80,6 @@ func IterateConsensusMetadata(store sdk.KVStore, cb func(key, val []byte) bool)
 	iterator := sdk.KVStorePrefixIterator(store, []byte(host.KeyConsensusStatePrefix))
 
 	// iterate over processed time and processed height
-	defer iterator.Close()
 	for ; iterator.Valid(); iterator.Next() {
 		keySplit := strings.Split(string(iterator.Key()), "/")
 		// processed time key in prefix store has format: "consensusState/<height>/processedTime"
@@ -99,6 +98,8 @@ func IterateConsensusMetadata(store sdk.KVStore, cb func(key, val []byte) bool)
 		}
 	}
 
+	iterator.Close()
+
 	// iterate over iteration keys
 	iterator = sdk.KVStorePrefixIterator(store, []byte(KeyIterateConsensusStatePrefix))