fix TestValidateBasic packet (#7775)

Co-authored-by: Gjermund Garaba <gjermund@garaba.net>
cosmos · Dec 20, 2024 · 18162f0 · 18162f0
1 parent 6201c79
commit 18162f0
Showing 1 changed file with 9 additions and 8 deletions.
diff --git a/modules/apps/27-interchain-accounts/types/packet_test.go b/modules/apps/27-interchain-accounts/types/packet_test.go
@@ -11,7 +11,7 @@ func (suite *TypesTestSuite) TestValidateBasic() {
 	testCases := []struct {
 		name       string
 		packetData types.InterchainAccountPacketData
-		expPass    bool
+		expErr     error
 	}{
 		{
 			"success",
@@ -20,15 +20,15 @@ func (suite *TypesTestSuite) TestValidateBasic() {
 				Data: []byte("data"),
 				Memo: "memo",
 			},
-			true,
+			nil,
 		},
 		{
 			"success, empty memo",
 			types.InterchainAccountPacketData{
 				Type: types.EXECUTE_TX,
 				Data: []byte("data"),
 			},
-			true,
+			nil,
 		},
 		{
 			"type unspecified",
@@ -37,7 +37,7 @@ func (suite *TypesTestSuite) TestValidateBasic() {
 				Data: []byte("data"),
 				Memo: "memo",
 			},
-			false,
+			types.ErrInvalidOutgoingData,
 		},
 		{
 			"empty data",
@@ -46,7 +46,7 @@ func (suite *TypesTestSuite) TestValidateBasic() {
 				Data: []byte{},
 				Memo: "memo",
 			},
-			false,
+			types.ErrInvalidOutgoingData,
 		},
 		{
 			"nil data",
@@ -55,7 +55,7 @@ func (suite *TypesTestSuite) TestValidateBasic() {
 				Data: nil,
 				Memo: "memo",
 			},
-			false,
+			types.ErrInvalidOutgoingData,
 		},
 		{
 			"memo too large",
@@ -64,7 +64,7 @@ func (suite *TypesTestSuite) TestValidateBasic() {
 				Data: []byte("data"),
 				Memo: ibctesting.GenerateString(types.MaxMemoCharLength + 1),
 			},
-			false,
+			types.ErrInvalidOutgoingData,
 		},
 	}
 
@@ -75,10 +75,11 @@ func (suite *TypesTestSuite) TestValidateBasic() {
 
 			err := tc.packetData.ValidateBasic()
 
-			if tc.expPass {
+			if tc.expErr == nil {
 				suite.Require().NoError(err)
 			} else {
 				suite.Require().Error(err)
+				suite.Require().ErrorIs(err, tc.expErr)
 			}
 		})
 	}