Skip to content

Commit

Permalink
fix: return correct types in wasm tests and add expected err
Browse files Browse the repository at this point in the history
  • Loading branch information
damiannolan committed Feb 21, 2024
1 parent fb7b6b5 commit 197f24f
Showing 1 changed file with 21 additions and 4 deletions.
25 changes: 21 additions & 4 deletions modules/light-clients/08-wasm/types/querier_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,7 @@ func (suite *TypesTestSuite) TestStargateQuery() {
testCases := []struct {
name string
malleate func()
expError error
}{
{
"success: custom query",
Expand Down Expand Up @@ -165,9 +166,13 @@ func (suite *TypesTestSuite) TestStargateQuery() {

store.Set(testKey, value)

return resp, wasmtesting.DefaultGasUsed, nil
result, err := json.Marshal(types.TimestampAtHeightResult{})
suite.Require().NoError(err)

return result, wasmtesting.DefaultGasUsed, nil
})
},
nil,
},
{
// The following test sets a mock proof key and value in the ibc store and registers a query callback on the Status msg.
Expand Down Expand Up @@ -220,7 +225,10 @@ func (suite *TypesTestSuite) TestStargateQuery() {

suite.Require().True(respData.Success)

return resp, wasmtesting.DefaultGasUsed, nil
result, err := json.Marshal(types.TimestampAtHeightResult{})
suite.Require().NoError(err)

return result, wasmtesting.DefaultGasUsed, nil
})

suite.mockVM.RegisterSudoCallback(types.VerifyMembershipMsg{}, func(_ wasmvm.Checksum, _ wasmvmtypes.Env, sudoMsg []byte, store wasmvm.KVStore,
Expand All @@ -247,6 +255,7 @@ func (suite *TypesTestSuite) TestStargateQuery() {
return &wasmvmtypes.Response{Data: bz}, wasmtesting.DefaultGasUsed, nil
})
},
nil,
},
{
"failure: default querier",
Expand All @@ -270,6 +279,7 @@ func (suite *TypesTestSuite) TestStargateQuery() {
return nil, wasmtesting.DefaultGasUsed, err
})
},
wasmvmtypes.UnsupportedRequest{Kind: fmt.Sprintf("'%s' path is not allowed from the contract", typeURL)},
},
}

Expand All @@ -290,8 +300,15 @@ func (suite *TypesTestSuite) TestStargateQuery() {
// NOTE: we register query callbacks against: types.TimestampAtHeightMsg{}
// in practise, this can against any client state msg, however registering against types.StatusMsg{} introduces recursive loops
// due to test case: "success: verify membership query"
_, err = clientState.GetTimestampAtHeight(suite.chainA.GetContext(), clientStore, suite.chainA.App.AppCodec(), clienttypes.GetSelfHeight(suite.chainA.GetContext()))
suite.Require().NoError(err)
_, err = clientState.GetTimestampAtHeight(suite.chainA.GetContext(), clientStore, suite.chainA.App.AppCodec(), clienttypes.NewHeight(1, 100))

expPass := tc.expError == nil
if expPass {
suite.Require().NoError(err)
} else {
// use error contains as wasmvm errors do not implement errors.Is method
suite.Require().ErrorContains(err, tc.expError.Error())
}

if expDiscardedState {
suite.Require().False(clientStore.Has(testKey))
Expand Down

0 comments on commit 197f24f

Please sign in to comment.