Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
  • Loading branch information
DimitrisJim and crodriguezvega authored Jun 30, 2023
1 parent 0c59db8 commit 2615342
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions modules/core/04-channel/keeper/packet_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -692,7 +692,7 @@ func (suite *KeeperTestSuite) TestAcknowledgePacket() {

channelCap = suite.chainA.GetChannelCapability(path.EndpointA.ChannelConfig.PortID, path.EndpointA.ChannelID)
}, true},
{"success on channel in tryupgrade flush status in flushing", func() {
{"success on channel in tryupgrade and flush status in flushing", func() {
// setup uses an UNORDERED channel
suite.coordinator.Setup(path)

Expand Down Expand Up @@ -773,7 +773,7 @@ func (suite *KeeperTestSuite) TestAcknowledgePacket() {
suite.Require().NoError(err)
channelCap = suite.chainA.GetChannelCapability(path.EndpointA.ChannelConfig.PortID, path.EndpointA.ChannelID)
}, false},
{"channel in tryupgrade flush status not in flush", func() {
{"channel in tryupgrade and flush status not in flush", func() {
expError = types.ErrInvalidChannelState

suite.coordinator.Setup(path)
Expand Down Expand Up @@ -989,8 +989,8 @@ func (suite *KeeperTestSuite) TestAcknowledgePacket() {
}
}

// TestAcknowledgeFlush tests that Acknowledging the last in-flight packet moves the channel
// state to FLUSHINGCOMPLETE.
// TestAcknowledgeFlushStatus tests that Acknowledging the last in-flight packet moves the channel
// flush status to FLUSHCOMPLETE.
func (suite *KeeperTestSuite) TestAcknowledgeFlushStatus() {
var path *ibctesting.Path

Expand Down

0 comments on commit 2615342

Please sign in to comment.