add failing test case for NegotiateAppVersion

cosmos · Nov 5, 2021 · 62dd3d3 · 62dd3d3
1 parent e22684b
commit 62dd3d3
Showing 1 changed file with 50 additions and 19 deletions.
diff --git a/modules/apps/27-interchain-accounts/ibc_module_test.go b/modules/apps/27-interchain-accounts/ibc_module_test.go
@@ -183,10 +183,8 @@ func (suite *InterchainAccountsTestSuite) TestOnChanOpenInit() {
 			} else {
 				suite.Require().Error(err)
 			}
-
 		})
 	}
-
 }
 
 func (suite *InterchainAccountsTestSuite) TestOnChanOpenTry() {
@@ -483,26 +481,59 @@ func (suite *InterchainAccountsTestSuite) TestOnRecvPacket() {
 }
 
 func (suite *InterchainAccountsTestSuite) TestNegotiateAppVersion() {
-	suite.SetupTest()
-	path := NewICAPath(suite.chainA, suite.chainB)
-	suite.coordinator.SetupConnections(path)
+	var (
+		proposedVersion string
+	)
+	testCases := []struct {
+		name     string
+		malleate func()
+		expPass  bool
+	}{
+		{
+			"success", func() {}, true,
+		},
+		{
+			"invalid proposed version", func() {
+				proposedVersion = "invalid version"
+			}, false,
+		},
+	}
 
-	module, _, err := suite.chainA.GetSimApp().GetIBCKeeper().PortKeeper.LookupModuleByPort(suite.chainA.GetContext(), types.PortID)
-	suite.Require().NoError(err)
+	for _, tc := range testCases {
+		tc := tc
 
-	cbs, ok := suite.chainA.GetSimApp().GetIBCKeeper().Router.GetRoute(module)
-	suite.Require().True(ok)
+		suite.Run(tc.name, func() {
+			suite.SetupTest()
+			path := NewICAPath(suite.chainA, suite.chainB)
+			suite.coordinator.SetupConnections(path)
 
-	counterpartyPortID, err := types.GeneratePortID(TestOwnerAddress, path.EndpointA.ConnectionID, path.EndpointB.ConnectionID)
-	suite.Require().NoError(err)
+			module, _, err := suite.chainA.GetSimApp().GetIBCKeeper().PortKeeper.LookupModuleByPort(suite.chainA.GetContext(), types.PortID)
+			suite.Require().NoError(err)
 
-	counterparty := &channeltypes.Counterparty{
-		PortId:    counterpartyPortID,
-		ChannelId: path.EndpointB.ChannelID,
-	}
+			cbs, ok := suite.chainA.GetSimApp().GetIBCKeeper().Router.GetRoute(module)
+			suite.Require().True(ok)
+
+			counterpartyPortID, err := types.GeneratePortID(TestOwnerAddress, path.EndpointA.ConnectionID, path.EndpointB.ConnectionID)
+			suite.Require().NoError(err)
+
+			counterparty := &channeltypes.Counterparty{
+				PortId:    counterpartyPortID,
+				ChannelId: path.EndpointB.ChannelID,
+			}
+
+			proposedVersion = types.VersionPrefix
 
-	version, err := cbs.NegotiateAppVersion(suite.chainA.GetContext(), channeltypes.ORDERED, path.EndpointA.ConnectionID, types.PortID, *counterparty, types.VersionPrefix)
-	suite.Require().NoError(err)
-	suite.Require().NoError(types.ValidateVersion(version))
-	suite.Require().Equal(TestVersion, version)
+			tc.malleate()
+
+			version, err := cbs.NegotiateAppVersion(suite.chainA.GetContext(), channeltypes.ORDERED, path.EndpointA.ConnectionID, types.PortID, *counterparty, proposedVersion)
+			if tc.expPass {
+				suite.Require().NoError(err)
+				suite.Require().NoError(types.ValidateVersion(version))
+				suite.Require().Equal(TestVersion, version)
+			} else {
+				suite.Require().Error(err)
+				suite.Require().Empty(version)
+			}
+		})
+	}
 }