fix(statemachine)!: allow overwriting of 29-fee payee to relayer addr…

…ess (#5441)

Co-authored-by: Carlos Rodriguez <carlos@interchain.io>

modules/apps/29-fee/types/msgs.go

@@ -46,10 +46,6 @@ func (msg MsgRegisterPayee) ValidateBasic() error {
 		return err
 	}
 
-	if msg.Relayer == msg.Payee {
-		return errorsmod.Wrap(ibcerrors.ErrInvalidRequest, "relayer address and payee must not be equal")
-	}
-
 	_, err := sdk.AccAddressFromBech32(msg.Relayer)
 	if err != nil {
 		return errorsmod.Wrap(err, "failed to create sdk.AccAddress from relayer address")

modules/apps/29-fee/types/msgs_test.go

@@ -30,24 +30,24 @@ func TestMsgRegisterPayeeValidation(t *testing.T) {
 			true,
 		},
 		{
-			"invalid portID",
+			"success: relayer and payee are equal",
 			func() {
-				msg.PortId = ""
+				msg.Relayer = defaultAccAddress
+				msg.Payee = defaultAccAddress
 			},
-			false,
+			true,
 		},
 		{
-			"invalid channelID",
+			"invalid portID",
 			func() {
-				msg.ChannelId = ""
+				msg.PortId = ""
 			},
 			false,
 		},
 		{
-			"invalid request relayer and payee are equal",
+			"invalid channelID",
 			func() {
-				msg.Relayer = defaultAccAddress
-				msg.Payee = defaultAccAddress
+				msg.ChannelId = ""
 			},
 			false,
 		},