Skip to content

Commit

Permalink
Address more findings.
Browse files Browse the repository at this point in the history
  • Loading branch information
bznein committed Apr 8, 2024
1 parent 1e5d69a commit b8b4c4c
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 4 deletions.
2 changes: 1 addition & 1 deletion modules/core/exported/client.go
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package exported

import (
proto "github.com/cosmos/gogoproto/proto"
"github.com/cosmos/gogoproto/proto"

storetypes "cosmossdk.io/store/types"

Expand Down
9 changes: 6 additions & 3 deletions modules/core/keeper/msg_server_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,8 @@ func (suite *KeeperTestSuite) TestRecoverClient() {

// Assert that client status is now Active
clientStore := suite.chainA.App.GetIBCKeeper().ClientKeeper.ClientStore(suite.chainA.GetContext(), subjectPath.EndpointA.ClientID)
tmClientState := subjectPath.EndpointA.GetClientState().(*ibctm.ClientState)
tmClientState, ok := subjectPath.EndpointA.GetClientState().(*ibctm.ClientState)
suite.Require().True(ok)
suite.Require().Equal(tmClientState.Status(suite.chainA.GetContext(), clientStore, suite.chainA.App.AppCodec()), exported.Active)
} else {
suite.Require().Error(err)
Expand Down Expand Up @@ -870,7 +871,8 @@ func (suite *KeeperTestSuite) TestUpgradeClient() {
path.SetupClients()

var err error
clientState := path.EndpointA.GetClientState().(*ibctm.ClientState)
clientState, ok := path.EndpointA.GetClientState().(*ibctm.ClientState)
suite.Require().True(ok)
revisionNumber := clienttypes.ParseChainID(clientState.ChainId)

newChainID, err = clienttypes.SetRevisionNumber(clientState.ChainId, revisionNumber+1)
Expand Down Expand Up @@ -2574,7 +2576,8 @@ func (suite *KeeperTestSuite) TestIBCSoftwareUpgrade() {
Height: 1000,
}
// update trusting period
clientState := path.EndpointB.GetClientState().(*ibctm.ClientState)
clientState, ok := path.EndpointB.GetClientState().(*ibctm.ClientState)
suite.Require().True(ok)
clientState.TrustingPeriod += 100

var err error
Expand Down

0 comments on commit b8b4c4c

Please sign in to comment.