Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide an experimental Gaia branch for ICS29 Fee Middleware #1162

Closed
3 tasks
soareschen opened this issue Mar 22, 2022 · 6 comments
Closed
3 tasks

Provide an experimental Gaia branch for ICS29 Fee Middleware #1162

soareschen opened this issue Mar 22, 2022 · 6 comments

Comments

@soareschen
Copy link

soareschen commented Mar 22, 2022

Summary

The changes in #276 requires non-trivial changes to be made in Gaia. It would be great if an experimental branch of Gaia can be provided that uses the ibc-go version provided in #1981.

Having a Gaia fork with fee enabled would allow us to develop the fee feature in Hermes without having to wait for an official Gaia release. (informalsystems/hermes#1967) We would also able to provide early feedback in case we find any issue with the current design.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner
Copy link
Contributor

Is it not possible to use the simapp within ibc-go?

@crodriguezvega
Copy link
Contributor

I think @seantking and @damiannolan have set up something similar as the interchain-accounts-demo repo when they did the QA for alpha a few weeks, but it's not available in any repo yet.

@damiannolan
Copy link
Member

damiannolan commented Mar 22, 2022

We tested e2e using simapp, modifying the ica demo scripts to bootstrap two chains using this binary

@fedekunze
Copy link
Contributor

@soareschen Happy to add this functionality to the Evmos testnet to try it with Gaia. We are running on the latest version and we have already implemented 2 middlewares

@fig666
Copy link

fig666 commented Mar 22, 2022

🤔

@soareschen
Copy link
Author

Is it not possible to use the simapp within ibc-go?

Thanks for the suggestion! I just tried running the ibc-rs integration tests with simapp in informalsystems/hermes#1996 and it does seem to work!

In that case this issue can be closed, and we'll try and develop ICS29 support with the simapp. Will report if we encounter any issue with that.

CosmosCar pushed a commit to caelus-labs/ibc-go that referenced this issue Nov 6, 2023
… right errors (cosmos#1162)

<!--
Please read and fill out this form before submitting your PR.

Please make sure you have reviewed our contributors guide before
submitting your
first PR.
-->

## Overview
Closes: cosmos#1163 

<!-- 
Please provide an explanation of the PR, including the appropriate
context,
background, goal, and rationale. If there is an issue with this
information,
please provide a tl;dr and link the issue. 
-->

## Checklist

<!-- 
Please complete the checklist to ensure that the PR is ready to be
reviewed.

IMPORTANT:
PRs should be left in Draft until the below checklist is completed.
-->

- [x] New and updated code has appropriate documentation
- [x] New and updated code has new and/or updated testing
- [x] Required CI checks are passing
- [ ] Visual proof for any user facing features like CLI or
documentation updates
- [x] Linked issues closed with keywords
CosmosCar pushed a commit to caelus-labs/ibc-go that referenced this issue Nov 6, 2023
…165)

<!--
Please read and fill out this form before submitting your PR.

Please make sure you have reviewed our contributors guide before
submitting your
first PR.
-->

## Overview
Closes: cosmos#1049

Stacked on top of cosmos#1162

<!-- 
Please provide an explanation of the PR, including the appropriate
context,
background, goal, and rationale. If there is an issue with this
information,
please provide a tl;dr and link the issue. 
-->

## Checklist

<!-- 
Please complete the checklist to ensure that the PR is ready to be
reviewed.

IMPORTANT:
PRs should be left in Draft until the below checklist is completed.
-->

- [x] New and updated code has appropriate documentation
- [x] New and updated code has new and/or updated testing
- [x] Required CI checks are passing
- [ ] Visual proof for any user facing features like CLI or
documentation updates
- [x] Linked issues closed with keywords

---------

Co-authored-by: Matthew Sevey <mjsevey@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants