Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update godoc for VerifyClientMessage in 07-tendermint #1185

Closed
3 tasks
colin-axner opened this issue Mar 28, 2022 · 1 comment
Closed
3 tasks

Update godoc for VerifyClientMessage in 07-tendermint #1185

colin-axner opened this issue Mar 28, 2022 · 1 comment
Assignees
@colin-axner
Labels
02-client 07-tendermint
Milestone
02-client refacto...

Comments

@colin-axner
Copy link
Contributor

Summary

godoc introduced by #1119 can be improved upon. It should emphasis the validation done by verifyHeader and verifyMisbehaviour in a useful manner without going into too much detail but without being too vague

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner colin-axner self-assigned this Mar 28, 2022
@colin-axner colin-axner moved this to Todo in ibc-go Mar 29, 2022
@crodriguezvega crodriguezvega added this to the 02-client refactor milestone Mar 30, 2022
@colin-axner colin-axner mentioned this issue Apr 21, 2022
Merged
9 tasks
@colin-axner colin-axner moved this from Todo to In review in ibc-go Apr 21, 2022
@crodriguezvega crodriguezvega moved this from In review to Done in ibc-go Apr 29, 2022
@crodriguezvega
Copy link
Contributor

Closed by #1281

CosmosCar pushed a commit to caelus-labs/ibc-go that referenced this issue Nov 6, 2023
@dependabot
build(deps): bump github.com/creachadair/taskgroup from 0.6.0 to 0.6.1 (
0a6aea3 
cosmos#1185)

Bumps
[github.com/creachadair/taskgroup](https://github.com/creachadair/taskgroup)
from 0.6.0 to 0.6.1.
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/creachadair/taskgroup/commit/ca5e7d74e3ed068c85f61cc89ffb60a9a6d9099f"><code>ca5e7d7</code></a>
Release v0.6.1</li>
<li><a
href="https://github.com/creachadair/taskgroup/commit/6b83f6e7cb87a75b8a872d1100ebbe32a69effbf"><code>6b83f6e</code></a>
Update actions/checkout to v4.</li>
<li><a
href="https://github.com/creachadair/taskgroup/commit/c07898bac76f0126d109eeea65328a283339f1d7"><code>c07898b</code></a>
.github: update go-presubmit-action to v2</li>
<li><a
href="https://github.com/creachadair/taskgroup/commit/c771f64a0f2f8fbbce3fdaa7215c3c0c01e78d78"><code>c771f64</code></a>
Bump Go toolchain base to 1.20</li>
<li><a
href="https://github.com/creachadair/taskgroup/commit/edfb9679968b7615f99a9675cbd90c3e5d8c3ecf"><code>edfb967</code></a>
Add a Get convenience method to Result[T].</li>
<li><a
href="https://github.com/creachadair/taskgroup/commit/b94c0ce5c71b17d4b1623f3207792fc91250eb0b"><code>b94c0ce</code></a>
Use rand.Shuffle instead of hand-rolling.</li>
<li>See full diff in <a
href="https://github.com/creachadair/taskgroup/compare/v0.6.0...v0.6.1">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github.com/creachadair/taskgroup&package-manager=go_modules&previous-version=0.6.0&new-version=0.6.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@crodriguezvega crodriguezvega moved this from Todo to Done in ibc-go Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@colin-axner colin-axner

Labels
02-client 07-tendermint
Projects
ibc-go
Status: Done 🥳
Milestone
02-client refactor alpha
Development

No branches or pull requests
2 participants
@crodriguezvega @colin-axner