You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Should be done after #1193 and #1190 . Add UpdateState to the ClientState interface. If #1193 added the call to UpdateStateOnMisbehaviour before CheckHeaderAndUpdateState then the same change can be made
For Admin Use
Not duplicate issue
Appropriate labels applied
Appropriate contributors tagged/assigned
The text was updated successfully, but these errors were encountered:
Hmm. Not returning the ClientState makes the API clean and it is a bit more clear to developers they need to set the ClientState. Returning the ClientState does allow for one less store query/less gas used, but it does open the possibility to a developer returning a different client state than that set in state (although hopefully not problematic if the returned client state is used for events only)
Hmm. Not returning the ClientState makes the API clean and it is a bit more clear to developers they need to set the ClientState. Returning the ClientState does allow for one less store query/less gas used, but it does open the possibility to a developer returning a different client state than that set in state (although hopefully not problematic if the returned client state is used for events only)
This is a good point. I'm actually more fond of APIs that return the updated values but as you point out this may not actually be the case.
I'm fine with leaving it out and doing an additional query to the store.
Summary
Should be done after #1193 and #1190 . Add
UpdateState
to the ClientState interface. If #1193 added the call toUpdateStateOnMisbehaviour
beforeCheckHeaderAndUpdateState
then the same change can be madeFor Admin Use
The text was updated successfully, but these errors were encountered: