Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

07-tendermint should set own client/consensus states in UpdateState #1190

Closed
3 tasks
colin-axner opened this issue Mar 29, 2022 · 0 comments
Closed
3 tasks

07-tendermint should set own client/consensus states in UpdateState #1190

colin-axner opened this issue Mar 29, 2022 · 0 comments
Assignees
@damiannolan
Labels
02-client 07-tendermint
Milestone
02-client refacto...

Comments

@colin-axner
Copy link
Contributor

Summary

The 07-tendermint UpdateState should set own client/consensus states. A check should be added in tests for this. Similar to #1144

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner colin-axner mentioned this issue Mar 29, 2022
Closed
3 tasks
@colin-axner colin-axner moved this to Todo in ibc-go Mar 29, 2022
@damiannolan damiannolan self-assigned this Mar 30, 2022
@damiannolan damiannolan moved this from Todo to In progress in ibc-go Mar 30, 2022
@damiannolan damiannolan mentioned this issue Mar 30, 2022
Merged
9 tasks
Repository owner moved this from In progress to Done in ibc-go Mar 30, 2022
@crodriguezvega crodriguezvega added this to the 02-client refactor milestone Mar 30, 2022
CosmosCar pushed a commit to caelus-labs/ibc-go that referenced this issue Nov 6, 2023
@gupadhyaya @nashqueue
updated README.md with releases (cosmos#1190)
68bd58f 
<!--
Please read and fill out this form before submitting your PR.

Please make sure you have reviewed our contributors guide before
submitting your
first PR.
-->

## Overview

<!-- 
Please provide an explanation of the PR, including the appropriate
context,
background, goal, and rationale. If there is an issue with this
information,
please provide a tl;dr and link the issue. 
-->

## Checklist

<!-- 
Please complete the checklist to ensure that the PR is ready to be
reviewed.

IMPORTANT:
PRs should be left in Draft until the below checklist is completed.
-->

- [ ] New and updated code has appropriate documentation
- [ ] New and updated code has new and/or updated testing
- [ ] Required CI checks are passing
- [ ] Visual proof for any user facing features like CLI or
documentation updates
- [ ] Linked issues closed with keywords

---------

Co-authored-by: Ganesha Upadhyaya <gupadhyaya@Ganeshas-MacBook-Pro-2.local>
Co-authored-by: nashqueue <99758629+nashqueue@users.noreply.github.com>
@crodriguezvega crodriguezvega moved this from Todo to Done in ibc-go Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@damiannolan damiannolan

Labels
02-client 07-tendermint
Projects
ibc-go
Status: Done 🥳
Milestone
02-client refactor alpha
Development

No branches or pull requests
3 participants
@damiannolan @crodriguezvega @colin-axner