Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emit event in RefundFeesOnChannelClosure #1323

Closed
crodriguezvega opened this issue May 1, 2022 · 1 comment · Fixed by #1344
Closed

Emit event in RefundFeesOnChannelClosure #1323

crodriguezvega opened this issue May 1, 2022 · 1 comment · Fixed by #1344
Assignees
@colin-axner
Labels
29-fee
Milestone
Fee middleware RC

Comments

@crodriguezvega
Copy link
Contributor

Emit event after emission upon successful cacheCtx write RefundFeesOnChannelClosure

@crodriguezvega crodriguezvega added this to the Fee middleware RC milestone May 1, 2022
@crodriguezvega crodriguezvega moved this to Todo in ibc-go May 1, 2022
@colin-axner
Copy link
Contributor 

// NOTE: The context returned by CacheContext() refers to a new EventManager, so it needs to explicitly set events to the original context.
	ctx.EventManager().EmitEvents(cacheCtx.EventManager().Events())

@colin-axner colin-axner self-assigned this May 4, 2022
@colin-axner colin-axner mentioned this issue May 9, 2022
Merged
9 tasks
@crodriguezvega crodriguezvega moved this from Todo to In review in ibc-go May 10, 2022
@mergify mergify bot closed this as completed in #1344 May 11, 2022
mergify bot pushed a commit that referenced this issue May 11, 2022
@colin-axner
fix: emit ics29 events on cacheCtx write after refunding on closed ch…
ab8ab42 
…annel (#1344)

## Description



closes: #1323 

---

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

- [ ] Targeted PR against correct branch (see [CONTRIBUTING.md](https://github.com/cosmos/ibc-go/blob/master/CONTRIBUTING.md#pr-targeting))
- [ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
- [ ] Code follows the [module structure standards](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules/structure.md).
- [ ] Wrote unit and integration [tests](https://github.com/cosmos/ibc-go/blob/master/CONTRIBUTING.md#testing)
- [ ] Updated relevant documentation (`docs/`) or specification (`x/<module>/spec/`)
- [ ] Added relevant `godoc` [comments](https://blog.golang.org/godoc-documenting-go-code).
- [ ] Added a relevant changelog entry to the `Unreleased` section in `CHANGELOG.md`
- [ ] Re-reviewed `Files changed` in the Github PR explorer
- [ ] Review `Codecov Report` in the comment section below once CI passes
Repository owner moved this from In review to Done in ibc-go May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@colin-axner colin-axner

Labels
29-fee
Projects
ibc-go
Archived in project
Milestone
Fee middleware RC
Development

Successfully merging a pull request may close this issue.

fix: emit ics29 events on cacheCtx write after refunding on closed channel cosmos/ibc-go
2 participants
@crodriguezvega @colin-axner