-
Notifications
You must be signed in to change notification settings - Fork 586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add heights to every gRPC request #149
Comments
* add batching to KVStore * add batch for PrefixKV
@colin-axner any progress/updates on this? I'm working on integrating IBC in Rust into Astria and have run into this as a major issue, since I would rather use only gRPC requests rather than the ABCI + gRPC combo. I'm happy to take this issue on! |
doesn't appear that this was closed due to some blocker so don't see why you couldn't take it on and push it through, rationale still appears to hold 😄. cc @crodriguezvega for a second opinion. |
No, this hasn't been implemented and there hasn't been any progress, so thanks @noot if you want to work on it. For reference, here's a PR where Colin started to work on this but eventually closed. |
great, thanks @DimitrisJim and @crodriguezvega ! I'll take this on then :) |
I am going to tentatively put this in v11... |
Summary
Heights are not included in gRPC requests as the height can be set in the SDK context. This isn't very useful for non-go implementations which might have a difficult time setting the SDK context correctly.
We should add a height request into the gRPC requests.
ibc-rs
is currently having difficulty doing gRPC requests at specific heights.The height in the request seems sufficiently generalized that other implementations could implement the same gRPC routes with the same proto files
cc @fedekunze
For Admin Use
The text was updated successfully, but these errors were encountered: