Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ics27 middleware enabled key to ics27 simulation #2166

Closed
3 tasks
colin-axner opened this issue Aug 31, 2022 · 0 comments · Fixed by #2215
Closed
3 tasks

Add ics27 middleware enabled key to ics27 simulation #2166

colin-axner opened this issue Aug 31, 2022 · 0 comments · Fixed by #2215
Assignees
@colin-axner
Labels
27-interchain-accounts
Milestone
v6.0.0

Comments

@colin-axner
Copy link
Contributor

Summary

A new storage key has been added. It needs to be handled in the decoder.go within ics27 simulation directory

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner colin-axner added this to the v5.1.0 milestone Aug 31, 2022
@crodriguezvega crodriguezvega moved this to Todo in ibc-go Sep 5, 2022
@colin-axner colin-axner self-assigned this Sep 6, 2022
@colin-axner colin-axner mentioned this issue Sep 7, 2022
Merged
9 tasks
@colin-axner colin-axner moved this from Todo to In review in ibc-go Sep 7, 2022
@mergify mergify bot closed this as completed in #2215 Sep 12, 2022
mergify bot pushed a commit that referenced this issue Sep 12, 2022
@colin-axner
chore: add IsMiddlewareEnabled key to simulation store decoder (#2215)
489fdf4 
## Description



closes: #2166 

---

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

- [ ] Targeted PR against correct branch (see [CONTRIBUTING.md](https://github.com/cosmos/ibc-go/blob/master/CONTRIBUTING.md#pr-targeting))
- [ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
- [ ] Code follows the [module structure standards](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules/structure.md).
- [ ] Wrote unit and integration [tests](https://github.com/cosmos/ibc-go/blob/master/CONTRIBUTING.md#testing)
- [ ] Updated relevant documentation (`docs/`) or specification (`x/<module>/spec/`)
- [ ] Added relevant `godoc` [comments](https://blog.golang.org/godoc-documenting-go-code).
- [ ] Added a relevant changelog entry to the `Unreleased` section in `CHANGELOG.md`
- [ ] Re-reviewed `Files changed` in the Github PR explorer
- [ ] Review `Codecov Report` in the comment section below once CI passes
Repository owner moved this from In review to Done in ibc-go Sep 12, 2022
mergify bot pushed a commit that referenced this issue Sep 12, 2022
@colin-axner @mergify
chore: add IsMiddlewareEnabled key to simulation store decoder (#2215)
437c473 
## Description

closes: #2166

---

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

- [ ] Targeted PR against correct branch (see [CONTRIBUTING.md](https://github.com/cosmos/ibc-go/blob/master/CONTRIBUTING.md#pr-targeting))
- [ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
- [ ] Code follows the [module structure standards](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules/structure.md).
- [ ] Wrote unit and integration [tests](https://github.com/cosmos/ibc-go/blob/master/CONTRIBUTING.md#testing)
- [ ] Updated relevant documentation (`docs/`) or specification (`x/<module>/spec/`)
- [ ] Added relevant `godoc` [comments](https://blog.golang.org/godoc-documenting-go-code).
- [ ] Added a relevant changelog entry to the `Unreleased` section in `CHANGELOG.md`
- [ ] Re-reviewed `Files changed` in the Github PR explorer
- [ ] Review `Codecov Report` in the comment section below once CI passes

(cherry picked from commit 489fdf4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@colin-axner colin-axner

Labels
27-interchain-accounts
Projects
ibc-go
Archived in project
Milestone
v6.0.0
Development

Successfully merging a pull request may close this issue.

chore: add IsMiddlewareEnabled key to simulation store decoder cosmos/ibc-go
1 participant
@colin-axner